Even more test cleanup. Some fixes to non-test code.

chrome/browser/geolocation/arbitrator_dependency_factories_for_test.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/geolocation/arbitrator_dependency_factories_for_test.h"
+
+GeolocationArbitratorDependencyFactoryWithLocationProvider::
+GeolocationArbitratorDependencyFactoryWithLocationProvider(

[Nico, 2011/02/15 21:25:37]

indent 4? also below.

this is a terrible class name

+    LocationProviderFactoryFunction factory_function)
+    : factory_function_(factory_function) {
+}
+
+GeolocationArbitratorDependencyFactoryWithLocationProvider::
+~GeolocationArbitratorDependencyFactoryWithLocationProvider() {}
+
+LocationProviderBase*
+GeolocationArbitratorDependencyFactoryWithLocationProvider::
+NewNetworkLocationProvider(
+    AccessTokenStore* access_token_store,
+    URLRequestContextGetter* context,
+    const GURL& url,
+    const string16& access_token) {
+  return factory_function_();
+}
+
+LocationProviderBase*
+GeolocationArbitratorDependencyFactoryWithLocationProvider::
+NewSystemLocationProvider() {
+  return NULL;
+}