Issue 6523025: Enable compound assignment to context slots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6523025: Enable compound assignment to context slots. (Closed)

Created:
9 years, 10 months ago by rossberg

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Enable compound assignment to context slots. Committed: http://code.google.com/p/v8/source/detail?r=6798

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	src/hydrogen.cc	View		4 chunks	+18 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 10 months ago (2011-02-15 16:34:58 UTC) #2

LGTM.

http://codereview.chromium.org/6523025/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6523025/diff/1/src/hydrogen.cc#newcode4735
src/hydrogen.cc:4735: BAILOUT("non-stack/non-global variable in count
operation");
"non-stack/non-global" ==> "lookup"

Expand Messages | Collapse Messages