Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 6523002: Fixes crash in instant. The crash would occur if a malware was showing (Closed)

Created:
9 years, 10 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes crash in instant. The crash would occur if a malware was showing and you hit escape. The regression is the result of converting to TabContentsWrapper and not updating a set_delegate from TabContentsWrapper to TabContents. BUG=72518 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/instant/instant_loader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 10 months ago (2011-02-14 22:16:11 UTC) #1
Ben Goodger (Google)
9 years, 10 months ago (2011-02-14 22:24:02 UTC) #2
OK

On Mon, Feb 14, 2011 at 2:16 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Fixes crash in instant. The crash would occur if a malware was showing
> and you hit escape. The regression is the result of converting to
> TabContentsWrapper and not updating a set_delegate from
> TabContentsWrapper to TabContents.
>
> BUG=72518
> TEST=none
>
> Please review this at http://codereview.chromium.org/6523002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/chrome
>
> Affected files:
>  M chrome/browser/instant/instant_loader.cc
>
>
> Index: chrome/browser/instant/instant_loader.cc
> diff --git a/chrome/browser/instant/instant_loader.cc
> b/chrome/browser/instant/instant_loader.cc
> index
>
7e2b6f05fd490f0f0e5e433b794eccbf920786c9..67c1501edbf39fd1c8a36f47e816f94279ed4b72
> 100644
> --- a/chrome/browser/instant/instant_loader.cc
> +++ b/chrome/browser/instant/instant_loader.cc
> @@ -619,7 +619,7 @@ TabContentsWrapper*
> InstantLoader::ReleasePreviewContents(
>           Source<NavigationController>(&preview_contents_->controller()));
>  #endif
>     }
> -    preview_contents_->set_delegate(NULL);
> +    preview_contents_->tab_contents()->set_delegate(NULL);
>     preview_tab_contents_delegate_->Reset();
>     ready_ = false;
>   }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698