Issue 652227: Allow snapshots built without -DANDROID to work on Android....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652227: Allow snapshots built without -DANDROID to work on Android.... (Closed)

Created:
10 years, 10 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow snapshots built without -DANDROID to work on Android. Fix bug in fast code generator on ARM (can't use ip as scratch in RecordWrite). Activate normal-sized compilation cache on Android. This is a port of 3938 from the partial snapshots branch. Committed: http://code.google.com/p/v8/source/detail?r=3992

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -30 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compilation-cache.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/fast-codegen.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/serialize.cc	View	1	1 chunk	+22 lines, -18 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

http://codereview.chromium.org/652227/diff/1/4 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/652227/diff/1/4#newcode170 src/ia32/macro-assembler-ia32.cc:170: and_(Operand(value), Immediate(ExternalReference::new_space_mask())); Should this be done on x64 as ...

10 years, 10 months ago (2010-02-24 14:17:49 UTC) #2

LGTM.

Expand Messages | Collapse Messages