Vboot reference: A basic user-land verified boot firmware signing and verification utility.

Vboot reference:  A basic user-land verified boot firmware signing and verification utility.

This is a first cut at what I envision as a utility we can use to manage our firmware/kernel signing needs. Currently, it implements firmware signing (given a binary image, create a verified boot header) and verification (given a verified boot image, verify it using the given public root key).

This CL also fixes the ReadFirmwareImage function from firmware_image to make it more consistent and fixes some bugs.

[Will Drewry, 2010-02-26 21:56:23]

Some style nits but LGTM.

I'll take another (closer) pass through either before or after commit.

thanks!

http://codereview.chromium.org/652216/diff/1012/1022
File src/platform/vboot_reference/utils/firmware_utility.cc (right):

http://codereview.chromium.org/652216/diff/1012/1022#newcode115
src/platform/vboot_reference/utils/firmware_utility.cc:115: key_version_ =
atoi(optarg);
if errors matter here, you may want to consider strtol().

http://codereview.chromium.org/652216/diff/1012/1022#newcode242
src/platform/vboot_reference/utils/firmware_utility.cc:242: if (root_key_file_
== "") {
It's nicer to check use root_key_file_.empty() (or length() == 0) since it's
preferred to avoid using some of the overload operators if possible.  (For
instance, I had to look at the .h file to know if this was a std::string or if
you were actually comparing a char * to a "" ;)

http://codereview.chromium.org/652216/diff/1012/1022#newcode246
src/platform/vboot_reference/utils/firmware_utility.cc:246: if
(firmware_version_ <= 0 || firmware_version_ > 0xFFFF) {
Should 0xFFFF be USHRT_MAX from limits.h?  Or is it a constant elsewhere?

[gauravsh, 2010-02-26 23:10:21]

Thanks, submitting.

http://codereview.chromium.org/652216/diff/1012/1022
File src/platform/vboot_reference/utils/firmware_utility.cc (right):

http://codereview.chromium.org/652216/diff/1012/1022#newcode115
src/platform/vboot_reference/utils/firmware_utility.cc:115: key_version_ =
atoi(optarg);
On 2010/02/26 21:56:23, Will Drewry wrote:
> if errors matter here, you may want to consider strtol().

Done.

http://codereview.chromium.org/652216/diff/1012/1022#newcode242
src/platform/vboot_reference/utils/firmware_utility.cc:242: if (root_key_file_
== "") {
On 2010/02/26 21:56:23, Will Drewry wrote:
> It's nicer to check use root_key_file_.empty() (or length() == 0) since it's
> preferred to avoid using some of the overload operators if possible.  (For
> instance, I had to look at the .h file to know if this was a std::string or if
> you were actually comparing a char * to a "" ;)
Done.

http://codereview.chromium.org/652216/diff/1012/1022#newcode246
src/platform/vboot_reference/utils/firmware_utility.cc:246: if
(firmware_version_ <= 0 || firmware_version_ > 0xFFFF) {
On 2010/02/26 21:56:23, Will Drewry wrote:
> Should 0xFFFF be USHRT_MAX from limits.h?  Or is it a constant elsewhere?

It's the max 16-bit value. All types used by the verification code are fixed
sizes. I think short is not guaranteed to be 16-bits, so I am leaving this
as-is.