add ffmpeg_tests into autotest. unfortunately for now the x86 binary is checked in

add ffmpeg_tests into autotest. 
1. only fps is checked now.
2. assume the media file is either at the bindir or hosted on the website.
3. unfortunately for now the x86 binary is checked in

[jiesun, 2010-02-23 21:44:51]

for initial code review

[fbarchard, 2010-02-23 21:46:22]

On 2010/02/23 21:44:51, jiesun wrote:
> for initial code review

Should you include the ffmpeg binaries as well?
Would you like ARM binaries?

[jiesun, 2010-02-26 18:17:09]

We are still not sure how to manage binaries in Autotest. probably not for now. 
Darin: could you give this another look.

[petkov, 2010-02-26 18:24:26]

In the interest of time, let's go with binaries until we figure a way to pull
the binaries from the Chrome build. Jie and I will keep looking into that.

Mark the binary with the target architecture -- e.g., suffix with .i686.

http://codereview.chromium.org/652154/diff/1/2
File client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py (right):

http://codereview.chromium.org/652154/diff/1/2#newcode71
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:71: logging.info("Cpu
Usage %s; FPS: %s" % (cpu_usage, fps))
Can we generate performance keyvals too? Collect in a keyval map and write at
the end of run_once.

http://codereview.chromium.org/652154/diff/1/2#newcode73
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:73: if fps < 30.0:
I'm not sure this belongs here -- we can add constraints based on the keyvals
outside the main benchmark. See suite_HWQual/control.auto.

http://codereview.chromium.org/652154/diff/1/5
File client/site_tests/audiovideo_FFMPEG/testcases (right):

http://codereview.chromium.org/652154/diff/1/5#newcode1
client/site_tests/audiovideo_FFMPEG/testcases:1:
#http://www.avatarmovie.com/videos/trailer_720p.mov
Chromium copyright?

[jiesun, 2010-02-26 20:18:32]

done with review issues

http://codereview.chromium.org/652154/diff/1/2
File client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py (right):

http://codereview.chromium.org/652154/diff/1/2#newcode71
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:71: logging.info("Cpu
Usage %s; FPS: %s" % (cpu_usage, fps))
On 2010/02/26 18:24:26, petkov wrote:
> Can we generate performance keyvals too? Collect in a keyval map and write at
> the end of run_once.

Done.

http://codereview.chromium.org/652154/diff/1/2#newcode73
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:73: if fps < 30.0:
On 2010/02/26 18:24:26, petkov wrote:
> I'm not sure this belongs here -- we can add constraints based on the keyvals
> outside the main benchmark. See suite_HWQual/control.auto.

Done.

[petkov, 2010-02-26 20:44:08]

http://codereview.chromium.org/652154/diff/3010/3011
File client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py (right):

http://codereview.chromium.org/652154/diff/3010/3011#newcode12
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:12: preserve_srcdir =
True
Remove -- you don't have a srcdir now.

http://codereview.chromium.org/652154/diff/3010/3011#newcode16
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:16:
os.chdir(self.srcdir)
Get rid of setup for now.

http://codereview.chromium.org/652154/diff/3010/3011#newcode78
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:78:
self.write_perf_keyval(performance_results)
Collect the keyvals in a self.performance_results and write them once at the end
of run_once. Otherwise you can't set constraints.

Convention for keys is <units>_<name>. E.g., fps_video_name. So, switch to
convention and include the video name in the key to uniquefy the keys.

http://codereview.chromium.org/652154/diff/3010/3014
File client/site_tests/audiovideo_FFMPEG/testcases (right):

http://codereview.chromium.org/652154/diff/3010/3014#newcode1
client/site_tests/audiovideo_FFMPEG/testcases:1:
http://www.avatarmovie.com/videos/trailer_720p.mov
Can you add the Chromium copyright header to this file?

[jiesun, 2010-02-26 21:21:48]

done

http://codereview.chromium.org/652154/diff/3010/3011
File client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py (right):

http://codereview.chromium.org/652154/diff/3010/3011#newcode12
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:12: preserve_srcdir =
True
On 2010/02/26 20:44:08, petkov wrote:
> Remove -- you don't have a srcdir now.
> 

Done.

http://codereview.chromium.org/652154/diff/3010/3011#newcode16
client/site_tests/audiovideo_FFMPEG/audiovideo_FFMPEG.py:16:
os.chdir(self.srcdir)
On 2010/02/26 20:44:08, petkov wrote:
> Get rid of setup for now.

Done.

http://codereview.chromium.org/652154/diff/3010/3014
File client/site_tests/audiovideo_FFMPEG/testcases (right):

http://codereview.chromium.org/652154/diff/3010/3014#newcode1
client/site_tests/audiovideo_FFMPEG/testcases:1:
http://www.avatarmovie.com/videos/trailer_720p.mov
On 2010/02/26 20:44:08, petkov wrote:
> Can you add the Chromium copyright header to this file?
> 

Done.

[petkov, 2010-02-26 22:00:58]

LGTM