Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 652147: Add xidle library to power_manager for testing how long the user has been idle (Closed)

Created:
10 years, 10 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
rtc
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add xidle library to power_manager for testing how long the user has been idle BUG=none TEST=included

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix issues pointed out by rtc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -0 lines) Patch
A src/platform/power_manager/SConstruct View 1 1 chunk +44 lines, -0 lines 0 comments Download
A src/platform/power_manager/testrunner.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A src/platform/power_manager/xidle.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A src/platform/power_manager/xidle.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
A src/platform/power_manager/xidle-example.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A src/platform/power_manager/xidle_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davidjames
10 years, 10 months ago (2010-02-23 20:25:25 UTC) #1
rtc
Please look at and fix the lint warnings as well. http://codereview.chromium.org/652147/diff/1/3 File src/platform/power_manager/xidle-test.cc (right): http://codereview.chromium.org/652147/diff/1/3#newcode8 ...
10 years, 10 months ago (2010-02-26 08:01:33 UTC) #2
davidjames
10 years, 9 months ago (2010-03-04 18:14:56 UTC) #3
rtc
10 years, 9 months ago (2010-03-08 18:55:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698