Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 652129: Programmatic bash completion for Chromium OS build scripts. (Closed)

Created:
10 years, 10 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
rtc, tedbo
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Programmatic bash completion for Chromium OS build scripts. If you source this script inside chroot, you would get <tab> completion for the --board= argument for some build scripts. For example, . bash_completion ./build_image --board=x<tab> may complete to ./build_image --board=x86-generic if x86-generic is the only available board starting with "x". If not, it will list available boards with the given prefix. We could extend this to work with setup_board and other scripts. Also, it may be nice to extend it to work outside chroot. Does it make sense to make this part of the regular dev chroot by default? If so, not sure what the best way to do that. Maybe install this as a hard-host-depends and source it from the chroot user .bashrc?

Patch Set 1 #

Patch Set 2 : Handle board overlays and some robustness. #

Patch Set 3 : Fix comment. #

Patch Set 4 : Fix comment. #

Patch Set 5 : Handle --arg foo as well (no equal). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A src/scripts/bash_completion View 1 2 3 4 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 10 months ago (2010-02-23 18:17:59 UTC) #1
rtc
10 years, 10 months ago (2010-02-24 02:12:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698