Issue 652118: Refactored TailCallRuntime (splitted to TailCallRuntime and TailCallExternalReference)

Issue 652118: Refactored TailCallRuntime (splitted to TailCallRuntime and TailCallExternalReference) (Closed)

Created:
10 years, 10 months ago by SeRya

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Committed: http://code.google.com/p/v8/source/detail?r=3937

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -129 lines)			Patch
M	src/arm/builtins-arm.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	9 chunks	+9 lines, -10 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1	8 chunks	+13 lines, -8 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+12 lines, -5 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	14 chunks	+15 lines, -18 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	8 chunks	+15 lines, -9 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1	2 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	11 chunks	+12 lines, -16 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	8 chunks	+13 lines, -8 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	2 chunks	+9 lines, -5 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/652118/diff/1/13 File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/652118/diff/1/13#newcode335 src/arm/macro-assembler-arm.h:335: // Call a runtime routine. The comment "Eventually ...

10 years, 10 months ago (2010-02-23 13:26:39 UTC) #2

SeRya

10 years, 10 months ago (2010-02-24 08:31:30 UTC) #3

http://codereview.chromium.org/652118/diff/1/13
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/652118/diff/1/13#newcode335
src/arm/macro-assembler-arm.h:335: // Call a runtime routine.
On 2010/02/23 13:26:40, Søren Gjesse wrote:
> The comment "Eventually this should be used for all C calls" seems to be
> obsolete.

Done.

http://codereview.chromium.org/652118/diff/1/13#newcode346
src/arm/macro-assembler-arm.h:346: // Tail call of a C routine (jump).
On 2010/02/23 13:26:40, Søren Gjesse wrote:
> I think we should keep this as runtime. When referring to runtime functions it
> is not only functions in runtime.cc, but both C and assembler function we call
> into from generated code. these functions don't expect normal C calling
> convention.
> 
> For the other architectures as well.

Done.

http://codereview.chromium.org/652118/diff/1/13#newcode358
src/arm/macro-assembler-arm.h:358: // Jump to a runtime routine.
On 2010/02/23 13:26:40, Søren Gjesse wrote:
> I think this should be renamed to JumpToExternalReference for consistency.
> 
> For the other architectures as well.

Done.

Expand Messages | Collapse Messages