Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 652114: Add the ability to compile with profiler guided optimizations on Windows... (Closed)

Created:
10 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add the ability to compile with profiler guided optimizations on Windows It is now possible to experiment with profiler guided optimizations when building V8. First build an instrumented sample shell: > scons pgo=instrument sample=shell Then run the JavaScript code to optimize for using that sample shell. Finally build an optimized sample shell. > scons pgo=optimize sample=shell Currently this does not work when building V8 as a DLL due to scons deleting v8.exp prior to the pgo=optimize step. Due to a bug in Visual Studio (seen in version 2008) the function MessageDispatchHelperThread::Run() in debug.cc needs to be empty for this to work. Committed: http://code.google.com/p/v8/source/detail?r=3934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M SConstruct View 7 chunks +31 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 10 months ago (2010-02-23 11:55:27 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-23 12:24:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698