Issue 652098: Add CHROME_* placeholders for setting official chrome versions for release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652098: Add CHROME_* placeholders for setting official chrome versions for release builds. (Closed)

Created:
10 years, 10 months ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Add CHROME_* placeholders for setting official chrome versions for release builds.

Patch Set 4 : version #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	src/scripts/chromeos_version.sh	View	1 2 3	3 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

http://codereview.chromium.org/652098/diff/1/2 File src/scripts/chromeos_version.sh (right): http://codereview.chromium.org/652098/diff/1/2#newcode87 src/scripts/chromeos_version.sh:87: export CHROME_BASE=http is 'http' a legit default, or just ...

10 years, 10 months ago (2010-02-23 01:31:45 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 652098: Add CHROME_* placeholders for setting official chrome versions for release builds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : version #

Patch Set 3 : version #

Patch Set 4 : version #

Messages