Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4188)

Unified Diff: chrome/renderer/renderer_webkitclient_impl.cc

Issue 652089: Add MessageLoop::QuitNow and use it to terminate a sync IPC.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop.cc ('k') | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/renderer_webkitclient_impl.cc
===================================================================
--- chrome/renderer/renderer_webkitclient_impl.cc (revision 39623)
+++ chrome/renderer/renderer_webkitclient_impl.cc (working copy)
@@ -131,12 +131,8 @@
// when there is no active script context.
int32 routing_id = RenderThread::RoutingIDForCurrentContext();
- // TODO(darin): We should use SendAndRunNestedMessageLoop here to avoid dead-
- // locking the browser, but this causes a performance regression. Switching
- // back to Send to verify. See http://crbug.com/36310.
-
std::string value_utf8;
- RenderThread::current()->Send(
+ RenderThread::current()->SendAndRunNestedMessageLoop(
new ViewHostMsg_GetCookies(routing_id, url, first_party_for_cookies,
&value_utf8));
« no previous file with comments | « base/message_loop.cc ('k') | ipc/ipc_sync_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698