Issue 652082: Add GPU performance constraints for hwqual purposes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652082: Add GPU performance constraints for hwqual purposes. (Closed)

Created:
10 years, 10 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Alexey Marinichev

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Add GPU performance constraints for hwqual purposes. Fix indent to match local style. Fix keyval generation so that constrains can be applied. Still missing the shader benchmark -- and the setup rate needs to be revisited.

Patch Set 1 #

Total comments: 2

Patch Set 2 : No need to strip() before float(). #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -13 lines)			Patch
	M	client/site_tests/gl_Bench/gl_Bench.py	View	1	1 chunk	+15 lines, -12 lines	0 comments	Download
	M	client/site_tests/suite_HWQual/control.auto	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexey Marinichev

Other than that LGTM. http://codereview.chromium.org/652082/diff/1/2 File client/site_tests/gl_Bench/gl_Bench.py (right): http://codereview.chromium.org/652082/diff/1/2#newcode30 client/site_tests/gl_Bench/gl_Bench.py:30: keyvals[key.strip()] = float(val.strip()) Float will ...

10 years, 10 months ago (2010-02-22 23:14:41 UTC) #2

petkov

10 years, 10 months ago (2010-02-22 23:21:20 UTC) #3

Submitting.

http://codereview.chromium.org/652082/diff/1/2
File client/site_tests/gl_Bench/gl_Bench.py (right):

http://codereview.chromium.org/652082/diff/1/2#newcode30
client/site_tests/gl_Bench/gl_Bench.py:30: keyvals[key.strip()] =
float(val.strip())
On 2010/02/22 23:14:41, Alexey Marinichev wrote:
> Float will strip before doing the conversion.

Done.

Expand Messages | Collapse Messages