Issue 652076: Linux: make sure the fullscreen window always gets focus...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652076: Linux: make sure the fullscreen window always gets focus... (Closed)

Created:
10 years, 10 months ago by Tristan Schmelcher 2

Modified:
9 years, 6 months ago

Reviewers:
piman

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Linux: make sure the fullscreen window always gets focus TEST=tested fullscreen on Linux with metacity, metacity + focus-follows-mouse, compiz, compiz + focus-follows-mouse BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39651

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	plugin/cross/o3d_glue.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	plugin/linux/main_linux.cc	View		3 chunks	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM http://codereview.chromium.org/652076/diff/7/8 File plugin/linux/main_linux.cc (right): http://codereview.chromium.org/652076/diff/7/8#newcode957 plugin/linux/main_linux.cc:957: // for obscure policy decisions (e.g., UI races). ...

10 years, 10 months ago (2010-02-22 22:41:52 UTC) #2

Tristan Schmelcher 2

10 years, 10 months ago (2010-02-22 22:44:36 UTC) #3

On 2010/02/22 22:41:52, piman wrote:
> LGTM
> 
> http://codereview.chromium.org/652076/diff/7/8
> File plugin/linux/main_linux.cc (right):
> 
> http://codereview.chromium.org/652076/diff/7/8#newcode957
> plugin/linux/main_linux.cc:957: // for obscure policy decisions (e.g., UI
> races).
> FYI the timestamp is most likely used to properly order requests because the
WM
> runs asynchronously, and could get requests from the client and X
out-of-order.

Ah right, of course. I forgot about the whole network-transparent thing. :) I've
changed the comment.

Expand Messages | Collapse Messages