Issue 652067: Cross compiling: don't rewrite dirs if they're already prefixed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652067: Cross compiling: don't rewrite dirs if they're already prefixed.... (Closed)

Created:
10 years, 10 months ago by adlr

Modified:
9 years ago

Reviewers:
DaveMoore

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Cross compiling: don't rewrite dirs if they're already prefixed. When compiling with the new portage build system for Chromium OS, paths passed in for includes, libraries, etc., are already properly prefixed with the sysroot and do not need to be again prefixed with the sysroot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39655

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/linux/rewrite_dirs.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

Dave, can you review this. When it looks good, would you mind committing it? Thanks,

10 years, 10 months ago (2010-02-22 21:12:14 UTC) #1

LGTM. I'll commit it.

Expand Messages | Collapse Messages