Issue 652044: Fix reliability crash caused by wrong assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652044: Fix reliability crash caused by wrong assert. (Closed)

Created:
10 years, 10 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix reliability crash caused by wrong assert. These two asserts in ComputeEntryFrame are wrong since the virtual frame already knows how to deal with the number type information of copy elements: We do not store type information with copy elements. Instead the backing element contains the type information. Committed: http://code.google.com/p/v8/source/detail?r=3927

Patch Set 1 #

Created: 10 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)
M	src/frame-element.h	View	1 chunk	+3 lines, -0 lines	0 comments
M	src/jump-target.cc	View	2 chunks	+0 lines, -2 lines	0 comments
M	src/jump-target-inl.h	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages