Issue 652040: Add patch for r11051 which fixes Valgrind bug 227570....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 652040: Add patch for r11051 which fixes Valgrind bug 227570.... (Closed)

Created:
10 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, Timur Iskhodzhanov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/scripts/

Visibility:
Public.

Description

Add patch for r11051 which fixes Valgrind bug 227570. This patch fixes a false warning about uninitialised memory access when invoking utimes(2). BUG=none TEST=remove the suppression, base_unittests should pass clean. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39704

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	build-valgrind-for-chromium.sh	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	vbug227570.patch	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

On 2010/02/22 09:04:22, jochen wrote: > please review LGTM Do you know how to cook ...

10 years, 10 months ago (2010-02-22 17:41:42 UTC) #2

jochen (gone - plz use gerrit)

10 years, 10 months ago (2010-02-23 09:32:34 UTC) #4

I'd prefer not to cook the binaries, it would be great if you could do that.

The patch should be applied on all three platforms, yes.

On 2010/02/22 17:41:42, Timur Iskhodzhanov wrote:
> On 2010/02/22 09:04:22, jochen wrote:
> > please review
> LGTM
> 
> Do you know how to cook Valgrind binaries to be put in SVN
> (http://dev.chromium.org/developers/how-tos/using-valgrind/building-valgrind)
> or should I do it for you?
> 
> I guess this patch should be applied to all three platforms - x86, x86_64 and
> mac.

Expand Messages | Collapse Messages