Issue 6520004: Introduce new runtime function to make join with lower memory usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6520004: Introduce new runtime function to make join with lower memory usage. (Closed)

Created:
9 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
sandholm, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Introduce new runtime function to make join with lower memory usage. Do not use generic StringBuilderConcat which requires array passed to keep both elements and separator (which roughly double size of the array). That should be faster as well. BUG=crbug.com/54580 Committed: http://code.google.com/p/v8/source/detail?r=6777

Patch Set 1 #

Patch Set 2 : Removing unnecessary file #

Total comments: 1

Patch Set 3 : Following Anders' advice #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -10 lines)			Patch
M	src/array.js	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download
M	test/mjsunit/fuzz-natives.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sandholm

9 years, 10 months ago (2011-02-14 15:23:04 UTC) #3

LGTM with one comment.

http://codereview.chromium.org/6520004/diff/2001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6520004/diff/2001/src/runtime.cc#newcode5856
src/runtime.cc:5856: bool ascii = separator->HasOnlyAsciiChars();
You will always need a TwoByteString.
If everything is ascii then the %_FastAsciiArrayJoin call in the array.js file
would have produced an ascii result already.
I.e. you can safely remove the ascii variable and checks and inline the
StringBuilderJoinHelper function.

Expand Messages | Collapse Messages