Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 6519057: Implement proxying for FileRef and FileChooser.... (Closed)

Created:
9 years, 10 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Implement proxying for FileRef and FileChooser. This also changes the FileRef interface to remove the Query function, since there is no close function, there's no way to cancel the current request, which makes memory management of the info structure very difficult. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75331

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ppapi tests to account for query change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -62 lines) Patch
M ppapi/c/dev/ppb_file_ref_dev.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M ppapi/c/private/ppb_proxy_private.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M ppapi/cpp/dev/file_ref_dev.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/file_ref_dev.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M ppapi/examples/file_chooser/file_chooser.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared_proxy.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 1 3 chunks +36 lines, -11 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 1 2 chunks +42 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_file_chooser_proxy.h View 1 chunk +66 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_file_chooser_proxy.cc View 1 chunk +246 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_file_ref_proxy.h View 1 chunk +86 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_file_ref_proxy.cc View 1 chunk +350 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_url_loader_proxy.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ppapi/proxy/serialized_structs.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/serialized_var.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M ppapi/tests/test_file_ref.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 2 chunks +0 lines, -24 lines 0 comments Download
M webkit/plugins/ppapi/ppb_proxy_impl.cc View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 10 months ago (2011-02-17 19:23:22 UTC) #1
piman
9 years, 10 months ago (2011-02-17 21:25:07 UTC) #2
LGTM with 2 nits

http://codereview.chromium.org/6519057/diff/1/ppapi/proxy/ppb_file_chooser_pr...
File ppapi/proxy/ppb_file_chooser_proxy.cc (right):

http://codereview.chromium.org/6519057/diff/1/ppapi/proxy/ppb_file_chooser_pr...
ppapi/proxy/ppb_file_chooser_proxy.cc:75: static_cast<int>(options->mode),
options->accept_mime_types, &result));
Is the static_cast necessary ? I'd assume the cast would be implicit.

http://codereview.chromium.org/6519057/diff/1/ppapi/proxy/serialized_var.cc
File ppapi/proxy/serialized_var.cc (right):

http://codereview.chromium.org/6519057/diff/1/ppapi/proxy/serialized_var.cc#n...
ppapi/proxy/serialized_var.cc:282: static_cast<SerializedVar&>(ret) =
serialized;
How about adding an explicit constructor for ReceiveSerializedVarReturnValue
that takes a const SerializedVar & and delegates to the SerializeVar copy
constructor ? That would be cleaner (no static cast required)

Powered by Google App Engine
This is Rietveld 408576698