Call accessors in the global object prototype when initializing global

Call accessors in the global object prototype when initializing global
variables.

Make the declaration of global const variables in the presence of
callbacks a redeclaration error.

Handle const context slot declarations conflicting with a CALLBACK as
a redeclaration error. That is, unless it is on a context extension
object which is not a real object and therefore conceptually have no
accessors in prototype chains. Accessors in prototype chains of
context extension objects are explicitly ignored in SetProperty.

Committed: http://code.google.com/p/v8/source/detail?r=6841

[Kevin Millikin (Chromium), 2011-02-17 16:01:17]

LGTM.

It's sort of ugly that "const" crosscuts so many different parts of the VM.

http://codereview.chromium.org/6519050/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6519050/diff/1/src/runtime.cc#newcode1085
src/runtime.cc:1085: if (lookup.IsProperty()) {
I think you can now write this as:

if (lookup.IsProperty() &&
    lookup.type() != INTERCEPTOR &&
    (lookup.IsReadOnly() || is_const_property)) {
  const char* type = (lookup.IsReadOnly()) ? "const" : "var";
  return ThrowRedeclarationError(type, name);
}
RETURN_IF_EMPTY_HANDLE(SetProperty(.....));

[Mads Ager (chromium), 2011-02-17 16:19:21]

Thanks. Yeah, const is not at all nice.

http://codereview.chromium.org/6519050/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6519050/diff/1/src/runtime.cc#newcode1085
src/runtime.cc:1085: if (lookup.IsProperty()) {
On 2011/02/17 16:01:17, Kevin Millikin wrote:
> I think you can now write this as:
> 
> if (lookup.IsProperty() &&
>     lookup.type() != INTERCEPTOR &&
>     (lookup.IsReadOnly() || is_const_property)) {
>   const char* type = (lookup.IsReadOnly()) ? "const" : "var";
>   return ThrowRedeclarationError(type, name);
> }
> RETURN_IF_EMPTY_HANDLE(SetProperty(.....));

Done.