Fix a bug in deoptimization after logical expressions in an effect context.

Fix a bug in deoptimization after logical expressions in an effect context.

When deoptimizing to after an expression of the form (expr0 || expr1)
or (expr0 && expr1) in an effect context, the unoptimized code could
incorrectly see the value of the expression.

Handle the short-circuit binary operators specially in effect contexts.
This fixes the issue and will generate better code when the left
subexpression is boolean-valued.

BUG=v8:1166
Committed: http://code.google.com/p/v8/source/detail?r=6831

[Kevin Millikin (Chromium), 2011-02-17 10:30:08]

In an effect context, we can visit the left-hand subexpression for its control
flow and the right-hand subexpression for effect.

[Mads Ager (chromium), 2011-02-17 10:35:34]

LGTM

http://codereview.chromium.org/6519046/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6519046/diff/1/src/hydrogen.cc#newcode5003
src/hydrogen.cc:5003: // TestContext::BuildBranch, and that they both have an
HSimulte
HSimulte -> HSimulate.

[Kevin Millikin (Chromium), 2011-02-17 11:05:42]

http://codereview.chromium.org/6519046/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6519046/diff/1/src/hydrogen.cc#newcode5003
src/hydrogen.cc:5003: // TestContext::BuildBranch, and that they both have an
HSimulte
On 2011/02/17 10:35:34, Mads Ager wrote:
> HSimulte -> HSimulate.
Thanks.