Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 6519039: Enhancements to bootperf, based on recent user feedback. (Closed)

Created:
9 years, 10 months ago by jrbarnette
Modified:
9 years, 6 months ago
Reviewers:
Sonny
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Enhancements to bootperf, based on recent user feedback. Enhancement 1: Fail if we run outside the chroot, because otherwise you have to wait 10 minutes to find out your results won't be gathered. Enhancement 2: Print the location of the log output file, for the benefits of looky-loos who want to see what's going on. Change-Id: I388b1855c5b6bb20b0efffbf0babd1f60caf7bcb BUG=None TEST=run the script per instructions, and see the new output TEST=run the script outside the chroot, and see it fail immediately Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=60a5ce0

Patch Set 1 #

Patch Set 2 : change format of stdout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M bootperf-bin/bootperf View 1 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jrbarnette
9 years, 10 months ago (2011-02-17 02:04:38 UTC) #1
Sonny
9 years, 10 months ago (2011-02-17 02:27:39 UTC) #2
tested it out, looks good to me

Powered by Google App Engine
This is Rietveld 408576698