Issue 6519035: Hide archive build output unless it fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6519035: Hide archive build output unless it fails. (Closed)

Created:
9 years, 10 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/chromite.git@master

Visibility:
Public.

Description

Hide archive build output unless it fails. Change-Id: I34422fc30d8643123e0b15d457c833de3e5cc7f3 BUG=chromium-os:12213 TEST=Ran it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=66c8c25

Patch Set 1 #

Patch Set 2 : Fix logic #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -6 lines)			Patch
	M	buildbot/cbuildbot.py	View	1	7 chunks	+28 lines, -5 lines	1 comment	Download
	M	lib/cros_build_lib.py	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

Two things ... Add combine_stderr_stdout param to new RunCommand in chromite. Use it and hide ...

9 years, 10 months ago (2011-02-17 03:58:51 UTC) #1

sosa

Redirecting to petkov as dgarrett is working on my other change and this is a ...

9 years, 10 months ago (2011-02-17 19:18:40 UTC) #2

petkov

9 years, 10 months ago (2011-02-17 19:31:14 UTC) #3

LGTM w/ a request below.

Note that I'm OK with always showing the archive build output (and that might be
preferable). But at same time print the archive location at the end of the log.

http://codereview.chromium.org/6519035/diff/2001/buildbot/cbuildbot.py
File buildbot/cbuildbot.py (right):

http://codereview.chromium.org/6519035/diff/2001/buildbot/cbuildbot.py#newcod...
buildbot/cbuildbot.py:533: result = RunCommand(cmd, cwd=cwd,
redirect_stdout=True,
Does this print the command? If not, can you Info "Archiving..." or something
like that?

Expand Messages | Collapse Messages