Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 6519022: Make mount points before attempting to mount on them (Closed)

Created:
9 years, 10 months ago by rochberg
Modified:
9 years, 7 months ago
Reviewers:
fes, Jason Glasgow, jglasgow
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Make mount points before attempting to mount on them BUG=chromium-os:11944 TEST=the correct test for this is a complete rebuild; I have this running, but it's going to take a little while. I have tested this on the specific cases of ssh_auth_sock and .subversion Change-Id: I61723356c58bfb7c2090e950208b8a6ab8fa2fc9 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=33373ef

Patch Set 1 #

Patch Set 2 : Ignore errors, comment #

Patch Set 3 : Do not ignore errors; we should fail if we can't make the directory #

Patch Set 4 : Typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M enter_chroot.sh View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rochberg
9 years, 10 months ago (2011-02-16 19:31:24 UTC) #1
jglasgow
9 years, 10 months ago (2011-02-16 19:47:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698