Use case-insensitive comparison when comparing JIDs.

remoting/host/access_verifier.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/access_verifier.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "remoting/host/host_config.h"
 #include "remoting/proto/auth.pb.h"
@@ skipping 17 matching lines @@
   initialized_ = true;
 
   return true;
 }
 
 bool AccessVerifier::VerifyPermissions(
     const std::string& client_jid,
     const std::string& encoded_access_token) {
   CHECK(initialized_);
   // Check that the client has the same bare jid as the host, i.e.
-  // client's full jid starts with host's bare jid.
-  if (!StartsWithASCII(client_jid, host_jid_prefix_, true)) {
+  // client's full JID starts with host's bare jid. Comparison is case
+  // insensitive.
+  if (!StartsWithASCII(client_jid, host_jid_prefix_, false)) {

[awong, 2011/02/14 20:25:54]

I'm thinking that we should preface this with an IsStringASCII check.

Reading through the jingle docs, it seems like they might not always be ascii if
we're outside of the google talk network (eg., federated XMPP user).

[Sergey Ulanov, 2011/02/14 21:38:20]

Added IsStringASCII() verification, not sure if it matters though:
StartsWithASCII() should ignore case only for ASCII characters.

[awong, 2011/02/14 21:59:06]

I'm not 100% sure it does... It falls down to strncasecmp which I would expect
understands locale and can do all sorts of fun things.

[Sergey Ulanov, 2011/02/14 22:05:36]

Yes, you are right. Thanks for catching this!

     return false;
   }
 
   // Decode the auth token.
   protocol::ClientAuthToken client_token;
   if (!DecodeClientAuthToken(encoded_access_token, &client_token)) {
     return false;
   }
 
   // Kick off directory access permissions.
   // TODO(ajwong): Actually implement this.
   return true;
 }
 
 bool AccessVerifier::DecodeClientAuthToken(
     const std::string& encoded_client_token,
     protocol::ClientAuthToken* client_token) {
   // TODO(ajwong): Implement this.
   NOTIMPLEMENTED();
   return true;
 }
 
 }  // namespace remoting