Use case-insensitive comparison when comparing JIDs.

Use case-insensitive comparison when comparing JIDs.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74866

[awong, 2011-02-14 20:25:54]

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
File remoting/host/access_verifier.cc (right):

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
remoting/host/access_verifier.cc:40: if (!StartsWithASCII(client_jid,
host_jid_prefix_, false)) {
I'm thinking that we should preface this with an IsStringASCII check.

Reading through the jingle docs, it seems like they might not always be ascii if
we're outside of the google talk network (eg., federated XMPP user).

[Sergey Ulanov, 2011-02-14 21:38:20]

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
File remoting/host/access_verifier.cc (right):

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
remoting/host/access_verifier.cc:40: if (!StartsWithASCII(client_jid,
host_jid_prefix_, false)) {
On 2011/02/14 20:25:54, awong wrote:
> I'm thinking that we should preface this with an IsStringASCII check.
> 
> Reading through the jingle docs, it seems like they might not always be ascii
if
> we're outside of the google talk network (eg., federated XMPP user).
Added IsStringASCII() verification, not sure if it matters though:
StartsWithASCII() should ignore case only for ASCII characters.

[awong, 2011-02-14 21:59:05]

LGTM

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
File remoting/host/access_verifier.cc (right):

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
remoting/host/access_verifier.cc:40: if (!StartsWithASCII(client_jid,
host_jid_prefix_, false)) {
On 2011/02/14 21:38:20, sergeyu wrote:
> On 2011/02/14 20:25:54, awong wrote:
> > I'm thinking that we should preface this with an IsStringASCII check.
> > 
> > Reading through the jingle docs, it seems like they might not always be
ascii
> if
> > we're outside of the google talk network (eg., federated XMPP user).
> Added IsStringASCII() verification, not sure if it matters though:
> StartsWithASCII() should ignore case only for ASCII characters.

I'm not 100% sure it does... It falls down to strncasecmp which I would expect
understands locale and can do all sorts of fun things.

[Sergey Ulanov, 2011-02-14 22:05:36]

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
File remoting/host/access_verifier.cc (right):

http://codereview.chromium.org/6518012/diff/3001/remoting/host/access_verifie...
remoting/host/access_verifier.cc:40: if (!StartsWithASCII(client_jid,
host_jid_prefix_, false)) {
On 2011/02/14 21:59:06, awong wrote:
> On 2011/02/14 21:38:20, sergeyu wrote:
> > On 2011/02/14 20:25:54, awong wrote:
> > > I'm thinking that we should preface this with an IsStringASCII check.
> > > 
> > > Reading through the jingle docs, it seems like they might not always be
> ascii
> > if
> > > we're outside of the google talk network (eg., federated XMPP user).
> > Added IsStringASCII() verification, not sure if it matters though:
> > StartsWithASCII() should ignore case only for ASCII characters.
> 
> I'm not 100% sure it does... It falls down to strncasecmp which I would expect
> understands locale and can do all sorts of fun things.
Yes, you are right. Thanks for catching this!