Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 6518004: Use ForceSetObjectProperty in DefineOrRedefineDataProperty (fixes crbug 72736... (Closed)

Created:
9 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use ForceSetObjectProperty in DefineOrRedefineDataProperty (fixes crbug 72736). The current version uses SetObjectProperty which will not set the value in case this is a readonly property. The spec explictly says that a configurable but non writable property can have its value changed with Object.defineProperty (because the same thing can be accomplished by doing 3 calls (set writable to true, update the value, set writable to false). Committed: http://code.google.com/p/v8/source/detail?r=6766

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 2 chunks +9 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-72736.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
9 years, 10 months ago (2011-02-14 10:03:52 UTC) #1
Rico
On 2011/02/14 10:03:52, Rico wrote: Forgot to mention, the stuff in v8natives is just style ...
9 years, 10 months ago (2011-02-14 10:20:44 UTC) #2
Mads Ager (chromium)
9 years, 10 months ago (2011-02-14 10:40:51 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698