Makefile - Issue 6517001: crash-reporter: Use standard logging and new libchromeos Process code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 6517001: crash-reporter: Use standard logging and new libchromeos Process code (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master

Patch Set: sync Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Makefile

diff --git a/Makefile b/Makefile

index 0523c199e367823f753de0a5794f6a93b79ceca2..c8039f45bca727c5cf6e1f7f1e1b069c7e259110 100644

--- a/Makefile

+++ b/Makefile

@@ -7,10 +7,9 @@ REPORTER_BINS = $(CRASH_REPORTER)

CRASH_OBJS = \

crash_collector.o \

kernel_collector.o \

- system_logging.o \

unclean_shutdown_collector.o \

user_collector.o

-TEST_OBJS = $(CRASH_OBJS) system_logging_mock.o

+TEST_OBJS = $(CRASH_OBJS)

TEST_BINS = \

crash_collector_test \

kernel_collector_test \

@@ -20,7 +19,7 @@ TEST_BINS = \

LDCONFIG = $(shell $(PKG_CONFIG) --libs libpcrecpp)

# -lglib-2.0 is needed by libbase.a now.

-COMMON_LIBS = -lbase -lpthread -lglib-2.0 -lgflags -lrt $(LDCONFIG)

+COMMON_LIBS = -lbase -lchromeos -lpthread -lglib-2.0 -lgflags -lrt $(LDCONFIG)

petkov 2011/02/25 19:28:34 Do you need to add a dependency to libchromeos to

REPORTER_LIBS = $(COMMON_LIBS) -lmetrics

TEST_LIBS = $(COMMON_LIBS) -lgtest -lgmock

« no previous file with comments | « no previous file | crash_collector.h » ('j') | no next file with comments »