Remove GetInputStreamBufferSize() method from FilterContext.

net/base/sdch_filter.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // SdchFilter applies open_vcdiff content decoding to a datastream.
 // This decoding uses a pre-cached dictionary of text fragments to decode
 // (expand) the stream back to its original contents.
 //
 // This SdchFilter internally uses open_vcdiff/vcdec library to do decoding.
 //
@@ skipping 11 matching lines @@
 #include "net/base/sdch_manager.h"
 
 namespace open_vcdiff {
 class VCDiffStreamingDecoder;
 }
 
 namespace net {
 
 class SdchFilter : public Filter {
  public:
-  explicit SdchFilter(const FilterContext& filter_context);
-
   virtual ~SdchFilter();
 
   // Initializes filter decoding mode and internal control blocks.
   bool InitDecoding(Filter::FilterType filter_type);
 
   // Decode the pre-filter data and writes the output into |dest_buffer|
   // The function returns FilterStatus. See filter.h for its description.
   //
   // Upon entry, *dest_len is the total size (in number of chars) of the
   // destination buffer. Upon exit, *dest_len is the actual number of chars
   // written into the destination buffer.
   virtual FilterStatus ReadFilteredData(char* dest_buffer, int* dest_len);
 
  private:
   // Internal status.  Once we enter an error state, we stop processing data.
   enum DecodingStatus {
     DECODING_UNINITIALIZED,
     WAITING_FOR_DICTIONARY_SELECTION,
     DECODING_IN_PROGRESS,
     DECODING_ERROR,
     META_REFRESH_RECOVERY,  // Decoding error being handled by a meta-refresh.
     PASS_THROUGH,  // Non-sdch content being passed without alteration.
   };
 
+  // Only to be instantiated by Filter::Factory.
+  explicit SdchFilter(const FilterContext& filter_context);

[jar (doing other things), 2011/03/01 22:44:03]

The moving of these constructors to being private is good.

Thanks!

+  friend class Filter;
+
   // Identify the suggested dictionary, and initialize underlying decompressor.
   Filter::FilterStatus InitializeDictionary();
 
   // Move data that was internally buffered (after decompression) to the
   // specified dest_buffer.
   int OutputBufferExcess(char* const dest_buffer, size_t available_space);
 
   // Tracks the status of decoding.
   // This variable is initialized by InitDecoding and updated only by
   // ReadFilteredData.
@@ skipping 45 matching lines @@
   // To facilitate error recovery, allow filter to know if content is text/html
   // by checking within this mime type (we may do a meta-refresh via html).
   std::string mime_type_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchFilter);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_FILTER_H_