Remove GetInputStreamBufferSize() method from FilterContext.

net/base/filter.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Filter performs filtering on data streams. Sample usage:
 //
 //   IStream* pre_filter_source;
 //   ...
 //   Filter* filter = Filter::Factory(filter_type, size);
 //   int pre_filter_data_len = filter->stream_buffer_size();
@@ skipping 25 matching lines @@
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "base/time.h"
 
 class GURL;
 
 namespace net {
 class IOBuffer;
+class SdchFilterChainingTest;
 }
 
 //------------------------------------------------------------------------------
 // Define an interface class that allows access to contextual information
 // supplied by the owner of this filter.  In the case where there are a chain of
 // filters, there is only one owner of all the chained filters, and that context
 // is passed to the constructor of all those filters.  To be clear, the context
 // does NOT reflect the position in a chain, or the fact that there are prior
 // or later filters in a chain.
 class FilterContext {
@@ skipping 31 matching lines @@
   virtual bool IsSdchResponse() const = 0;
 
   // How many bytes were read from the net or cache so far (and potentially
   // pushed into a filter for processing)?
   virtual int64 GetByteReadCount() const = 0;
 
   // What response code was received with the associated network transaction?
   // For example: 200 is ok.   4xx are error codes. etc.
   virtual int GetResponseCode() const = 0;
 
-  // What is the desirable input buffer size for these filters?
-  // This value is currently supplied by the context, and is constant for all
-  // filters, even when they are part of a chain of filters. (i.e., we currently
-  // don't change the input buffer sizes for a linked chain of filters, and the
-  // buffer size for input to all filters in a chain is this one constant).
-  virtual int GetInputStreamBufferSize() const = 0;
-
   // The following method forces the context to emit a specific set of
   // statistics as selected by the argument.
   virtual void RecordPacketStats(StatisticSelector statistic) const = 0;
 };
 
 //------------------------------------------------------------------------------
 class Filter {
  public:
   // Return values of function ReadFilteredData.
   enum FilterStatus {
@@ skipping 78 matching lines @@
   // to the list.  This includes handling known bugs in the Apache server (where
   // redundant gzip encoding is specified), as well as issues regarding SDCH
   // encoding, where various proxies and anti-virus products modify or strip the
   // encodings.  These fixups require context, which includes whether this
   // response was made to an SDCH request (i.e., an available dictionary was
   // advertised in the GET), as well as the mime type of the content.
   static void FixupEncodingTypes(const FilterContext& filter_context,
                                  std::vector<FilterType>* encoding_types);
 
  protected:
-  FRIEND_TEST_ALL_PREFIXES(SdchFilterTest, ContentTypeId);
+  friend class GZipUnitTest;
+  friend class net::SdchFilterChainingTest;
 
   explicit Filter(const FilterContext& filter_context);
 
   // Filters the data stored in stream_buffer_ and writes the output into the
   // dest_buffer passed in.
   //
   // Upon entry, *dest_len is the total size (in number of chars) of the
   // destination buffer. Upon exit, *dest_len is the actual number of chars
   // written into the destination buffer.
   //
@@ skipping 16 matching lines @@
   // Maximum size of stream_buffer_ in number of chars.
   int stream_buffer_size_;
 
   // Pointer to the next data in stream_buffer_ to be filtered.
   char* next_stream_data_;
 
   // Total number of remaining chars in stream_buffer_ to be filtered.
   int stream_data_len_;
 
  private:
+  // Allocates and initializes stream_buffer_ and stream_buffer_size_.
+  void InitBuffer(int size);
+
   // A factory helper for creating filters for within a chain of potentially
   // multiple encodings.  If a chain of filters is created, then this may be
   // called multiple times during the filter creation process.  In most simple
   // cases, this is only called once. Returns NULL and cleans up (deleting
   // filter_list) if a new filter can't be constructed.
   static Filter* PrependNewFilter(FilterType type_id,
                                   const FilterContext& filter_context,
+                                  int buffer_size,
                                   Filter* filter_list);
 
-  // Allocates and initializes stream_buffer_ based on filter_context_.
-  // Establishes a buffer large enough to handle the amount specified in
-  // filter_context_.GetInputStreamBufferSize().
-  bool InitBuffer();
-
   // Helper function to empty our output into the next filter's input.
   void PushDataIntoNextFilter();
 
+  // Constructs a filter with an internal buffer of the given size.
+  // Only meant to be called by unit tests that need to control the buffer size.
+  static Filter* FactoryForTests(const std::vector<FilterType>& filter_types,
+                                 const FilterContext& filter_context,
+                                 int buffer_size);
+
   // An optional filter to process output from this filter.
   scoped_ptr<Filter> next_filter_;
   // Remember what status or local filter last returned so we can better handle
   // chained filters.
   FilterStatus last_status_;
 
   // Context data from the owner of this filter.  Some filters need additional
   // context information (mime type, etc.) to properly function, and they access
   // this data via this reference member.
   const FilterContext& filter_context_;
 
   DISALLOW_COPY_AND_ASSIGN(Filter);
 };
 
 #endif  // NET_BASE_FILTER_H__