Linux: Refactor printing to be more like Windows/Mac....

chrome/browser/printing/print_view_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_view_manager.h"
 
 #include "base/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/printing/print_job.h"
@@ skipping 96 matching lines @@
   // Windows 2000/XP: When a page in a spooled file exceeds approximately 350
   // MB, it can fail to print and not send an error message.
   if (params.data_size && params.data_size >= 350*1024*1024) {
     NOTREACHED() << "size:" << params.data_size;
     TerminatePrintJob(true);
     owner_.Stop();
     return;
   }
 #endif
 
+  const bool metafile_must_be_valid =
+#if defined(OS_WIN) || defined(OS_MACOSX)
+      true;
+#elif defined(OS_POSIX)
+      (params.page_number == 0);
+#endif
+
   base::SharedMemory shared_buf(params.metafile_data_handle, true);
-  if (!shared_buf.Map(params.data_size)) {
-    NOTREACHED() << "couldn't map";
-    owner_.Stop();
-    return;
+  if (metafile_must_be_valid) {
+    if (!shared_buf.Map(params.data_size)) {
+      NOTREACHED() << "couldn't map";
+      owner_.Stop();
+      return;
+    }
   }
 
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
-  NOTIMPLEMENTED() << " this printing code doesn't quite work yet.";
-#else
   scoped_ptr<NativeMetafile> metafile(new NativeMetafile());
-  if (!metafile->Init(shared_buf.memory(), params.data_size)) {
-    NOTREACHED() << "Invalid metafile header";
-    owner_.Stop();
-    return;
+  if (metafile_must_be_valid) {
+    if (!metafile->Init(shared_buf.memory(), params.data_size)) {
+      NOTREACHED() << "Invalid metafile header";
+      owner_.Stop();
+      return;
+    }
   }
 
   // Update the rendered document. It will send notifications to the listener.
   document->SetPage(params.page_number,
                     metafile.release(),
                     params.actual_shrink,
                     params.page_size,
                     params.content_area,
                     params.has_visible_overlays);
-#endif
+
   ShouldQuitFromInnerMessageLoop();
 }
 
 bool PrintViewManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PrintViewManager, message)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidGetPrintedPagesCount,
                         OnDidGetPrintedPagesCount)
     IPC_MESSAGE_HANDLER(ViewHostMsg_DidPrintPage, OnDidPrintPage)
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ skipping 263 matching lines @@
     return false;
   }
 
   // Settings are already loaded. Go ahead. This will set
   // print_job_->is_job_pending() to true.
   print_job_->StartPrinting();
   return true;
 }
 
 }  // namespace printing