Made activate/buy button show consistently on network list and details pages....

chrome/browser/resources/options/chromeos_internet_options.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
 
   /////////////////////////////////////////////////////////////////////////////
   // InternetOptions class:
 
@@ skipping 35 matching lines @@
 
       $('wiredSection').hidden = (templateData.wiredList.length == 0);
       $('wirelessSection').hidden = (templateData.wirelessList.length == 0);
       $('rememberedSection').hidden = (templateData.rememberedList.length == 0);
       InternetOptions.setupAttributes(templateData);
       $('detailsInternetDismiss').addEventListener('click', function(event) {
         OptionsPage.closeOverlay();
       });
       $('detailsInternetLogin').addEventListener('click', function(event) {
         InternetOptions.loginFromDetails();
-      });;
+      });
       $('activateDetails').addEventListener('click', function(event) {
         InternetOptions.activateFromDetails();
       });
       $('enableWifi').addEventListener('click', function(event) {
         event.target.disabled = true;
         chrome.send('enableWifi', []);
       });
       $('disableWifi').addEventListener('click', function(event) {
         event.target.disabled = true;
         chrome.send('disableWifi', []);
@@ skipping 139 matching lines @@
     var page = $('detailsInternetPage');
     page.removeAttribute('cellplanloading');
     if (data.plans && data.plans.length) {
       page.removeAttribute('nocellplan');
       page.setAttribute('hascellplan', true);
       $('planList').load(data.plans);
     } else {
       page.setAttribute('nocellplan', true);
       page.removeAttribute('hascellplan');
     }
-    if (!data.needsPlan) {
+
+    if (!data.needsPlan)
       page.setAttribute('hasactiveplan', true);
-    } else {
+    else
       page.removeAttribute('hasactiveplan');
-    }
+
     if (data.activated) {
       page.setAttribute('activated', true);
     } else {
       page.removeAttribute('activated');
+      $('detailsInternetLogin').classList.add('hidden');
     }
 
+    // CSS selectors don't like me anymore, switching to classList
+    if (data.showBuyButton)
+      $('buyplanDetails').classList.remove('hidden');
+    else
+      $('buyplanDetails').classList.add('hidden');
+
+    if (data.showActivateButton)
+      $('activateDetails').classList.remove('hidden');
+    else
+      $('activateDetails').classList.add('hidden');
+
     // Nudge webkit so that it redraws the details overlay page.
     // See http://crosbug.com/9616 for details.
     // Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=50176
     var dummy = page.ownerDocument.createTextNode(' ');
     page.appendChild(dummy);
     page.removeChild(dummy);
   };
 
   InternetOptions.showPasswordEntry = function (data) {
     var element = $(data.servicePath);
     element.showPassword();
   };
 
   InternetOptions.showDetailedInfo = function (data) {
     var page = $('detailsInternetPage');
-    if (data.connected) {
-      $('inetTitle').textContent = localStrings.getString('inetStatus');
-    } else {
-      $('inetTitle').textContent = localStrings.getString('inetConnect');
-    }
+    $('buyplanDetails').classList.add('hidden');
+    $('activateDetails').classList.add('hidden');
+    $('detailsInternetLogin').classList.add('hidden');
     if (data.connecting) {
       page.setAttribute('connecting', data.connecting);
     } else {
       page.removeAttribute('connecting');
     }
     if (data.connected) {
       page.setAttribute('connected', data.connected);
+      $('inetTitle').textContent = localStrings.getString('inetStatus');
     } else {
       page.removeAttribute('connected');
+      $('inetTitle').textContent = localStrings.getString('inetConnect');
+      $('detailsInternetLogin').classList.remove('hidden');
     }
     $('connectionState').textContent = data.connectionState;
     var address = $('inetAddress');
     address.data = data;
     if (data.ipconfigs && data.ipconfigs.length) {
       // We will be displaying only the first ipconfig info for now until we
       // start supporting multiple IP addresses per connection.
       address.textContent = data.ipconfigs[0].address;
       $('inetSubnetAddress').textContent = data.ipconfigs[0].subnetAddress;
       $('inetGateway').textContent = data.ipconfigs[0].gateway;
@@ skipping 66 matching lines @@
       $('esn').textContent = data.esn;
       $('min').textContent = data.min;
       if (!data.gsm) {
         page.removeAttribute('gsm');
       } else {
         $('operatorName').textContent = data.operatorName;
         $('operatorCode').textContent = data.operatorCode;
         $('imsi').textContent = data.imsi;
         page.setAttribute('gsm', true);
       }
+
+      // CSS selectors don't like me anymore, switching to classList
+      if (data.showBuyButton)
+        $('buyplanDetails').classList.remove('hidden');
+      else
+        $('buyplanDetails').classList.add('hidden');
+
+      if (data.showActivateButton) {
+        $('activateDetails').classList.remove('hidden')
+        $('detailsInternetLogin').classList.add('hidden');
+      } else {
+        $('activateDetails').classList.add('hidden');
+      }
+
       page.removeAttribute('hascellplan');
       if (data.connected) {
         page.removeAttribute('nocellplan');
         page.setAttribute('cellplanloading', true);
         chrome.send('refreshCellularPlan', [data.servicePath])
       } else {
         page.setAttribute('nocellplan', true);
         page.removeAttribute('cellplanloading');
       }
     } else {
       OptionsPage.showTab($('internetNavTab'));
       page.setAttribute('ethernet', true);
       page.removeAttribute('wireless');
       page.removeAttribute('cert');
       page.removeAttribute('certPkcs');
       page.removeAttribute('cellular');
       page.removeAttribute('gsm');
     }
     OptionsPage.navigateToPage('detailsInternetPage');
   };
 
   // Export
   return {
     InternetOptions: InternetOptions
   };
 });