Made activate/buy button show consistently on network list and details pages....

Made activate/buy button show consistently on network list and details pages.

BUG=chromium-os:10937
TEST=make sure [Activate] button does not show in connection details if the device is already activated


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75304

[Charlie Lee, 2011-02-14 20:50:32]

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:652: if
(show_activate || cellular->needs_new_plan()) {
I think this logic should be changed to:

if (needs_new_plan())
  dictionary->SetBoolean...
else if (activation_state != ... && activations_state != ...)
  dictionary->SetBoolean...

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:654:
dictionary->SetBoolean('showBuyButton', true);
use double quotes so it's consistent

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:656:
dictionary->SetBoolean('showActivateButton', true);
use double quotes so it's consistent

http://codereview.chromium.org/6516019/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos_internet_options_page.css
(right):

http://codereview.chromium.org/6516019/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos_internet_options_page.css:196:
#detailsInternetPage[cellplanloading]  > * > #buyplanDetails,
Is this line a copy & paster error?

[zel, 2011-02-17 00:56:04]

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
File chrome/browser/chromeos/dom_ui/internet_options_handler.cc (right):

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:652: if
(show_activate || cellular->needs_new_plan()) {
On 2011/02/14 20:50:32, Charlie Lee wrote:
> I think this logic should be changed to:
> 
> if (needs_new_plan())
>   dictionary->SetBoolean...
> else if (activation_state != ... && activations_state != ...)
>   dictionary->SetBoolean...

Done.

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:654:
dictionary->SetBoolean('showBuyButton', true);
On 2011/02/14 20:50:32, Charlie Lee wrote:
> use double quotes so it's consistent

Done.

http://codereview.chromium.org/6516019/diff/1/chrome/browser/chromeos/dom_ui/...
chrome/browser/chromeos/dom_ui/internet_options_handler.cc:656:
dictionary->SetBoolean('showActivateButton', true);
On 2011/02/14 20:50:32, Charlie Lee wrote:
> use double quotes so it's consistent

Done.

http://codereview.chromium.org/6516019/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos_internet_options_page.css
(right):

http://codereview.chromium.org/6516019/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos_internet_options_page.css:196:
#detailsInternetPage[cellplanloading]  > * > #buyplanDetails,
On 2011/02/14 20:50:32, Charlie Lee wrote:
> Is this line a copy & paster error?

I have removed most selectors related to these two buttons because they simply
don't work. I will need to file WK bug on this one.

[Charlie Lee, 2011-02-17 01:11:54]

LGTM