Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 6516016: Refactor construction of polymorphic loads, stores, and calls. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor construction of polymorphic loads, stores, and calls. Rather than passing in a pair of unequal-length lists, pass the default subgraph separately. Construct the typecase from the top down rather than the bottom up, so it doesn't need an intermediate zone list. Also, change a basic block's 'last' instruction field to really be its last instruction by correctly updating it when inserting and removing instructions. Committed: http://code.google.com/p/v8/source/detail?r=6783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -82 lines) Patch
M src/hydrogen.h View 3 chunks +7 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 16 chunks +56 lines, -76 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-14 18:43:11 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-15 07:47:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698