Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 6516008: Add support for the global object in Object.keys (fixes issue 1150)... (Closed)

Created:
9 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add support for the global object in Object.keys (fixes issue 1150) We do not currently handle the case where the JSGlobalProxy is passed as argument to LocalKeys in runtime.cc. Committed: http://code.google.com/p/v8/source/detail?r=6762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M src/runtime.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-1150.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 10 months ago (2011-02-14 07:44:25 UTC) #1
Mads Ager (chromium)
9 years, 10 months ago (2011-02-14 07:46:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698