Issue 6516003: Strict mode delete of unqualified identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6516003: Strict mode delete of unqualified identifier. (Closed)

Created:
9 years, 10 months ago by Martin Maly

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Strict mode delete of unqualified identifier. SyntaxError is reported in strict mode when deleting an unqualified identifier. (11.4.1 of Ecma-262 5th Edition) BUG= TEST=test/mjsunit/strict-mode.js

Patch Set 2 : CR Feedback. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -19 lines)			Patch
M	src/messages.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/es5conform/es5conform.status	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	test/mjsunit/strict-mode.js	View	1	4 chunks	+48 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Martin Maly

Delete of an unqualified identifier is a syntax error.

9 years, 10 months ago (2011-02-13 19:36:25 UTC) #1

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6516003/diff/1/test/mjsunit/strict-mode.js File test/mjsunit/strict-mode.js (right): http://codereview.chromium.org/6516003/diff/1/test/mjsunit/strict-mode.js#newcode270 test/mjsunit/strict-mode.js:270: CheckStrictMode("function function_name() { delete function_name; }", SyntaxError); Split ...

9 years, 10 months ago (2011-02-14 09:00:12 UTC) #2