Move CC icons to chrome/common and implement loadPlatformResource in RendererWebKitClientImpl.

Move CC icons to chrome/common/resource/autofill and implement loadResource in RendererWebKitClientImpl. 

BUG=50685
TEST=Add credit card entries in autofilling. Go to a page which has credit card number filling form and make it autofill and check if the credit card icon are shown correctly.

[honten.org, 2011-02-13 19:32:41]

James,

Could you review?

As you know, this change needs WebKit side change, but needs to commit at once.

In that case, how should I do?

Thanks,

[honten.org, 2011-02-13 19:49:03]

Also, in my repo. I moved icons to chrome/common/resources, but it doesn't show
in CL.

Is there any other extra steps to apply move files?

On 2011/02/13 19:32:41, honten wrote:
> James,
> 
> Could you review?
> 
> As you know, this change needs WebKit side change, but needs to commit at
once.
> 
> In that case, how should I do?
> 
> Thanks,

[honten.org, 2011-02-15 18:36:41]

James,

Could you review my patch?

On 2011/02/13 19:49:03, honten wrote:
> Also, in my repo. I moved icons to chrome/common/resources, but it doesn't
show
> in CL.
> 
> Is there any other extra steps to apply move files?
> 
> On 2011/02/13 19:32:41, honten wrote:
> > James,
> > 
> > Could you review?
> > 
> > As you know, this change needs WebKit side change, but needs to commit at
> once.
> > 
> > In that case, how should I do?
> > 
> > Thanks,

[James Hawkins, 2011-02-15 18:51:34]

On 2011/02/15 18:36:41, honten wrote:
> James,
> 
> Could you review my patch?
> 
> On 2011/02/13 19:49:03, honten wrote:
> > Also, in my repo. I moved icons to chrome/common/resources, but it doesn't
> show
> > in CL.
> > 
> > Is there any other extra steps to apply move files?
> > 
> > On 2011/02/13 19:32:41, honten wrote:
> > > James,
> > > 
> > > Could you review?
> > > 
> > > As you know, this change needs WebKit side change, but needs to commit at
> > once.
> > > 
> > > In that case, how should I do?
> > > 
> > > Thanks,

You need to figure out why the icons aren't showing up in the CL.

[takano.naoki_gmail.com, 2011-02-15 19:04:16]

Ok, I'll figure it out.

On Tue, Feb 15, 2011 at 10:51 AM,  <jhawkins@chromium.org> wrote:
> On 2011/02/15 18:36:41, honten wrote:
>>
>> James,
>
>> Could you review my patch?
>
>> On 2011/02/13 19:49:03, honten wrote:
>> > Also, in my repo. I moved icons to chrome/common/resources, but it
>> > doesn't
>> show
>> > in CL.
>> >
>> > Is there any other extra steps to apply move files?
>> >
>> > On 2011/02/13 19:32:41, honten wrote:
>> > > James,
>> > >
>> > > Could you review?
>> > >
>> > > As you know, this change needs WebKit side change, but needs to commit
>> > > at
>> > once.
>> > >
>> > > In that case, how should I do?
>> > >
>> > > Thanks,
>
> You need to figure out why the icons aren't showing up in the CL.
>
> http://codereview.chromium.org/6516002/
>

[honten.org, 2011-02-16 03:30:36]

Hmmm.... Even git log shows correct file movement, git cl cannot upload
correctly;-(
It might have some restriction in git cl.

I try with svn again.

On 2011/02/15 19:04:16, takano.naoki_gmail.com wrote:
> Ok, I'll figure it out.
> 
> On Tue, Feb 15, 2011 at 10:51 AM,  <mailto:jhawkins@chromium.org> wrote:
> > On 2011/02/15 18:36:41, honten wrote:
> >>
> >> James,
> >
> >> Could you review my patch?
> >
> >> On 2011/02/13 19:49:03, honten wrote:
> >> > Also, in my repo. I moved icons to chrome/common/resources, but it
> >> > doesn't
> >> show
> >> > in CL.
> >> >
> >> > Is there any other extra steps to apply move files?
> >> >
> >> > On 2011/02/13 19:32:41, honten wrote:
> >> > > James,
> >> > >
> >> > > Could you review?
> >> > >
> >> > > As you know, this change needs WebKit side change, but needs to commit
> >> > > at
> >> > once.
> >> > >
> >> > > In that case, how should I do?
> >> > >
> >> > > Thanks,
> >
> > You need to figure out why the icons aren't showing up in the CL.
> >
> > http://codereview.chromium.org/6516002/
> >

[honten.org, 2011-02-16 06:42:00]

James,

Finally, I can upload file move with svn.

Please review.

On 2011/02/16 03:30:36, honten wrote:
> Hmmm.... Even git log shows correct file movement, git cl cannot upload
> correctly;-(
> It might have some restriction in git cl.
> 
> I try with svn again.
> 
> On 2011/02/15 19:04:16, http://takano.naoki_gmail.com wrote:
> > Ok, I'll figure it out.
> > 
> > On Tue, Feb 15, 2011 at 10:51 AM,  <mailto:jhawkins@chromium.org> wrote:
> > > On 2011/02/15 18:36:41, honten wrote:
> > >>
> > >> James,
> > >
> > >> Could you review my patch?
> > >
> > >> On 2011/02/13 19:49:03, honten wrote:
> > >> > Also, in my repo. I moved icons to chrome/common/resources, but it
> > >> > doesn't
> > >> show
> > >> > in CL.
> > >> >
> > >> > Is there any other extra steps to apply move files?
> > >> >
> > >> > On 2011/02/13 19:32:41, honten wrote:
> > >> > > James,
> > >> > >
> > >> > > Could you review?
> > >> > >
> > >> > > As you know, this change needs WebKit side change, but needs to
commit
> > >> > > at
> > >> > once.
> > >> > >
> > >> > > In that case, how should I do?
> > >> > >
> > >> > > Thanks,
> > >
> > > You need to figure out why the icons aren't showing up in the CL.
> > >
> > > http://codereview.chromium.org/6516002/
> > >

[James Hawkins, 2011-02-16 19:56:38]

+isherman, +dhollowa

Recusing myself.  I'm too far removed to be useful on this review, but I can
provide at least one more tip.  I now remember a bit more how this was supposed
to work.  The autofill code in third_party/WebKit should call
loadPlatformResource to get the icons for the select element.

[honten.org, 2011-02-16 20:11:35]

Ok,

Do you remember where it is in WebKit?

As I already wrote in CL description, I also uploaded another patch for WebKit.
Is this not enough?

Thanks,

On 2011/02/16 19:56:38, James Hawkins wrote:
> +isherman, +dhollowa
> 
> Recusing myself.  I'm too far removed to be useful on this review, but I can
> provide at least one more tip.  I now remember a bit more how this was
supposed
> to work.  The autofill code in third_party/WebKit should call
> loadPlatformResource to get the icons for the select element.

[honten.org, 2011-02-17 17:57:07]

Ilya,

Could you review my patch?

On 2011/02/16 20:11:35, honten wrote:
> Ok,
> 
> Do you remember where it is in WebKit?
> 
> As I already wrote in CL description, I also uploaded another patch for
WebKit.
> Is this not enough?
> 
> Thanks,
> 
> On 2011/02/16 19:56:38, James Hawkins wrote:
> > +isherman, +dhollowa
> > 
> > Recusing myself.  I'm too far removed to be useful on this review, but I can
> > provide at least one more tip.  I now remember a bit more how this was
> supposed
> > to work.  The autofill code in third_party/WebKit should call
> > loadPlatformResource to get the icons for the select element.

[dhollowa, 2011-02-17 19:56:55]

Honten, James, I'm unclear on the motivation here.  It seems undesirable to add
an additional method to the WebKitClient API when |loadResources| already does
the job.

What are we gaining?

[honten.org, 2011-02-17 20:09:04]

As you see here, http://code.google.com/p/chromium/issues/detail?id=50685

James insisted as following,

> re: loadPlatformResource. No, it means loadPlatformResource. ack-grep is your
friend.

I believe it is just refactoring, but actually I don't know his deep intention
here.

[honten.org, 2011-02-18 00:40:43]

Ilya,

Do you have any comment?

On 2011/02/17 20:09:04, honten wrote:
> As you see here, http://code.google.com/p/chromium/issues/detail?id=50685
> 
> James insisted as following,
> 
> > re: loadPlatformResource. No, it means loadPlatformResource. ack-grep is
your
> friend.
> 
> I believe it is just refactoring, but actually I don't know his deep intention
> here.

[Ilya Sherman, 2011-02-18 17:32:08]

Please note James's comment on the WebKit bug:

"When I said use loadPlatformResource() in the TODO, I mean
Image::loadPlatformResource()."

[takano.naoki_gmail.com, 2011-02-18 18:44:43]

Ilya and James,

Thank you for letting me know, Ilya and your comment, James.

But still I'm wondering why James pointed out "Image::loadPlatformResouces()".

I added my comment at
https://bugs.webkit.org/show_bug.cgi?id=54361

Could you give me your thought?

Thanks,

On Fri, Feb 18, 2011 at 9:32 AM,  <isherman@chromium.org> wrote:
> Please note James's comment on the WebKit bug:
>
> "When I said use loadPlatformResource() in the TODO, I mean
> Image::loadPlatformResource()."
>
> http://codereview.chromium.org/6516002/
>

[takano.naoki_gmail.com, 2011-02-18 19:26:10]

Ilya,

BTW, as you pointed out, I'll change the WebKit side source code, but
even I change the code, I believe I don't have to change chromium
code.

So could you review chrome side patch, if you have time?

Thanks,

On Fri, Feb 18, 2011 at 10:44 AM, Naoki Takano <takano.naoki@gmail.com> wrote:
> Ilya and James,
>
> Thank you for letting me know, Ilya and your comment, James.
>
> But still I'm wondering why James pointed out "Image::loadPlatformResouces()".
>
> I added my comment at
> https://bugs.webkit.org/show_bug.cgi?id=54361
>
> Could you give me your thought?
>
> Thanks,
>
> On Fri, Feb 18, 2011 at 9:32 AM,  <isherman@chromium.org> wrote:
>> Please note James's comment on the WebKit bug:
>>
>> "When I said use loadPlatformResource() in the TODO, I mean
>> Image::loadPlatformResource()."
>>
>> http://codereview.chromium.org/6516002/
>>
>

[Ilya Sherman, 2011-02-18 19:38:51]

On 2011/02/18 19:26:10, takano.naoki_gmail.com wrote:
> Ilya,
> 
> BTW, as you pointed out, I'll change the WebKit side source code, but
> even I change the code, I believe I don't have to change chromium
> code.
> 
> So could you review chrome side patch, if you have time?

I think the WebKit side -- if it needs to happen -- is the crux of the patch. 
I'm not sure how to review the chrome side without understanding the changes
there.

I do think it would be better to move the resources to
chrome/common/resources/autofill, though, so there's not just a jumble of
resources at the top level.

[honten.org, 2011-02-19 00:03:25]

Now we are back from WebKit side;-)

The conclusion is "not to add any new function into WebKit code, but just only
move icons to tests".

Ilya already suggested we should move them to chrome/common/resources/autofill/
I will change the patch and upload it tonight.

Thanks,

On 2011/02/18 19:38:51, Ilya Sherman wrote:
> On 2011/02/18 19:26:10, http://takano.naoki_gmail.com wrote:
> > Ilya,
> > 
> > BTW, as you pointed out, I'll change the WebKit side source code, but
> > even I change the code, I believe I don't have to change chromium
> > code.
> > 
> > So could you review chrome side patch, if you have time?
> 
> I think the WebKit side -- if it needs to happen -- is the crux of the patch. 
> I'm not sure how to review the chrome side without understanding the changes
> there.
> 
> I do think it would be better to move the resources to
> chrome/common/resources/autofill, though, so there's not just a jumble of
> resources at the top level.

[dhollowa, 2011-02-19 01:22:00]

Thank you Takano.  If you could rename the png files themselves too, like:
cc_amex.png, cc_generic.png, cc_diners.png, etc.  that'd be great.

On 2011/02/19 00:03:25, honten wrote:
> Now we are back from WebKit side;-)
> 
> The conclusion is "not to add any new function into WebKit code, but just only
> move icons to tests".
> 
> Ilya already suggested we should move them to
chrome/common/resources/autofill/
> I will change the patch and upload it tonight.
> 
> Thanks,
> 
> On 2011/02/18 19:38:51, Ilya Sherman wrote:
> > On 2011/02/18 19:26:10, http://takano.naoki_gmail.com wrote:
> > > Ilya,
> > > 
> > > BTW, as you pointed out, I'll change the WebKit side source code, but
> > > even I change the code, I believe I don't have to change chromium
> > > code.
> > > 
> > > So could you review chrome side patch, if you have time?
> > 
> > I think the WebKit side -- if it needs to happen -- is the crux of the
patch. 
> > I'm not sure how to review the chrome side without understanding the changes
> > there.
> > 
> > I do think it would be better to move the resources to
> > chrome/common/resources/autofill, though, so there's not just a jumble of
> > resources at the top level.

[honten.org, 2011-02-19 04:37:45]

Please review again.

[dhollowa, 2011-02-22 17:26:12]

LGTM.

On 2011/02/19 04:37:45, honten wrote:
> Please review again.

[takano.naoki_gmail.com, 2011-02-22 17:42:24]

Cool!!

Could you commit?

On Tue, Feb 22, 2011 at 9:26 AM,  <dhollowa@chromium.org> wrote:
> LGTM.
>
> On 2011/02/19 04:37:45, honten wrote:
>>
>> Please review again.
>
>
>
> http://codereview.chromium.org/6516002/
>

[honten.org, 2011-02-23 01:11:12]

Ilya,

If you are Ok, could you commit?

On 2011/02/22 17:42:24, takano.naoki_gmail.com wrote:
> Cool!!
> 
> Could you commit?
> 
> On Tue, Feb 22, 2011 at 9:26 AM,  <mailto:dhollowa@chromium.org> wrote:
> > LGTM.
> >
> > On 2011/02/19 04:37:45, honten wrote:
> >>
> >> Please review again.
> >
> >
> >
> > http://codereview.chromium.org/6516002/
> >

[Ilya Sherman, 2011-02-23 01:30:59]

Could you please update this patch to ToT?  The dom_ui folder was moved to
webui, so the patch no longer applies.

[takano.naoki_gmail.com, 2011-02-23 02:12:06]

Ah... ok...

On Tue, Feb 22, 2011 at 5:30 PM,  <isherman@chromium.org> wrote:
> Could you please update this patch to ToT?  The dom_ui folder was moved to
> webui, so the patch no longer applies.
>
> http://codereview.chromium.org/6516002/
>

[honten.org, 2011-02-23 06:58:58]

Hew.. I did it.

I was stuck because ld consumes fd more than default setting after I pull the
latest repo.

Anyway, please review again!!

On 2011/02/23 02:12:06, takano.naoki_gmail.com wrote:
> Ah... ok...
> 
> On Tue, Feb 22, 2011 at 5:30 PM,  <mailto:isherman@chromium.org> wrote:
> > Could you please update this patch to ToT? &nbsp;The dom_ui folder was moved
to
> > webui, so the patch no longer applies.
> >
> > http://codereview.chromium.org/6516002/
> >

[dhollowa, 2011-02-23 16:34:46]

I'm seeing a number of compile errors:

http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/13616/st...

make: *** No rule to make target `chrome/common/resources/autofill/cc_amex.png',
needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target
`chrome/common/resources/autofill/cc_diners.png', needed by
`out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target
`chrome/common/resources/autofill/cc_discover.png', needed by
`out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target
`chrome/common/resources/autofill/cc_generic.png', needed by
`out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target `chrome/common/resources/autofill/cc_jcb.png',
needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target
`chrome/common/resources/autofill/cc_mastercard.png', needed by
`out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target `chrome/common/resources/autofill/cc_solo.png',
needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
make: *** No rule to make target `chrome/common/resources/autofill/cc_visa.png',
needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.


On 2011/02/23 06:58:58, honten wrote:
> Hew.. I did it.
> 
> I was stuck because ld consumes fd more than default setting after I pull the
> latest repo.
> 
> Anyway, please review again!!
> 
> On 2011/02/23 02:12:06, http://takano.naoki_gmail.com wrote:
> > Ah... ok...
> > 
> > On Tue, Feb 22, 2011 at 5:30 PM,  <mailto:isherman@chromium.org> wrote:
> > > Could you please update this patch to ToT? &nbsp;The dom_ui folder was
moved
> to
> > > webui, so the patch no longer applies.
> > >
> > > http://codereview.chromium.org/6516002/
> > >

[honten.org, 2011-02-23 17:56:52]

dhollowa,

Thank you for your support. It looks like binary file errors.

As far as I know, try bot might now support binary files as following,

> My patch includes updated webkit baselines (binary files) and it's not working
> Correct! The try servers do not currently support binary patches, but this is
being worked on.

Please refer to FAQ in
http://www.chromium.org/developers/testing/try-server-usage

I believe the patch itself looks fine, but do you have any other idea   the
patch is wrong?

As you know, still I'm not commiter, so I need your help.

Actually I already landed more than 10 patches(including WebKit) so I could be
commiter though;-)

Thanks,

On 2011/02/23 16:34:46, dhollowa wrote:
> I'm seeing a number of compile errors:
> 
>
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/13616/st...
> 
> make: *** No rule to make target
`chrome/common/resources/autofill/cc_amex.png',
> needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
> `chrome/common/resources/autofill/cc_diners.png', needed by
> `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
> `chrome/common/resources/autofill/cc_discover.png', needed by
> `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
> `chrome/common/resources/autofill/cc_generic.png', needed by
> `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
`chrome/common/resources/autofill/cc_jcb.png',
> needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
> `chrome/common/resources/autofill/cc_mastercard.png', needed by
> `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
`chrome/common/resources/autofill/cc_solo.png',
> needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> make: *** No rule to make target
`chrome/common/resources/autofill/cc_visa.png',
> needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> 
> 
> On 2011/02/23 06:58:58, honten wrote:
> > Hew.. I did it.
> > 
> > I was stuck because ld consumes fd more than default setting after I pull
the
> > latest repo.
> > 
> > Anyway, please review again!!
> > 
> > On 2011/02/23 02:12:06, http://takano.naoki_gmail.com wrote:
> > > Ah... ok...
> > > 
> > > On Tue, Feb 22, 2011 at 5:30 PM,  <mailto:isherman@chromium.org> wrote:
> > > > Could you please update this patch to ToT? &nbsp;The dom_ui folder was
> moved
> > to
> > > > webui, so the patch no longer applies.
> > > >
> > > > http://codereview.chromium.org/6516002/
> > > >

[honten.org, 2011-02-23 18:03:02]

dhollowa,

Oops,

> As far as I know, try bot might now support binary files as following,
Here, "try bot might not support" is correct.


On 2011/02/23 17:56:52, honten wrote:
> dhollowa,
> 
> Thank you for your support. It looks like binary file errors.
> 
> As far as I know, try bot might now support binary files as following,
> 
> > My patch includes updated webkit baselines (binary files) and it's not
working
> > Correct! The try servers do not currently support binary patches, but this
is
> being worked on.
> 
> Please refer to FAQ in
> http://www.chromium.org/developers/testing/try-server-usage
> 
> I believe the patch itself looks fine, but do you have any other idea   the
> patch is wrong?
> 
> As you know, still I'm not commiter, so I need your help.
> 
> Actually I already landed more than 10 patches(including WebKit) so I could be
> commiter though;-)
> 
> Thanks,
> 
> On 2011/02/23 16:34:46, dhollowa wrote:
> > I'm seeing a number of compile errors:
> > 
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/13616/st...
> > 
> > make: *** No rule to make target
> `chrome/common/resources/autofill/cc_amex.png',
> > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_diners.png', needed by
> > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_discover.png', needed by
> > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_generic.png', needed by
> > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> `chrome/common/resources/autofill/cc_jcb.png',
> > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_mastercard.png', needed by
> > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> `chrome/common/resources/autofill/cc_solo.png',
> > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > make: *** No rule to make target
> `chrome/common/resources/autofill/cc_visa.png',
> > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > 
> > 
> > On 2011/02/23 06:58:58, honten wrote:
> > > Hew.. I did it.
> > > 
> > > I was stuck because ld consumes fd more than default setting after I pull
> the
> > > latest repo.
> > > 
> > > Anyway, please review again!!
> > > 
> > > On 2011/02/23 02:12:06, http://takano.naoki_gmail.com wrote:
> > > > Ah... ok...
> > > > 
> > > > On Tue, Feb 22, 2011 at 5:30 PM,  <mailto:isherman@chromium.org> wrote:
> > > > > Could you please update this patch to ToT? &nbsp;The dom_ui folder was
> > moved
> > > to
> > > > > webui, so the patch no longer applies.
> > > > >
> > > > > http://codereview.chromium.org/6516002/
> > > > >

[dhollowa, 2011-02-23 19:27:47]

Takano, after thinking about this a little more I'm uneasy with a couple points:
 
 (1) that this is Autofill specific, but if we are going to do this cleanup we
should be thinking more generally.  I.e. why not move all resources out of the
webkit glue layer?

 (2) the chrome/common/... area may not be were we want some of these resources
if they are renderer specific or browser specific.

Let me follow up with jam and darin to see what they think.

[honten.org, 2011-02-23 19:40:05]

Sure...


On 2011/02/23 18:03:02, honten wrote:
> dhollowa,
> 
> Oops,
> 
> > As far as I know, try bot might now support binary files as following,
> Here, "try bot might not support" is correct.
> 
> 
> On 2011/02/23 17:56:52, honten wrote:
> > dhollowa,
> > 
> > Thank you for your support. It looks like binary file errors.
> > 
> > As far as I know, try bot might now support binary files as following,
> > 
> > > My patch includes updated webkit baselines (binary files) and it's not
> working
> > > Correct! The try servers do not currently support binary patches, but this
> is
> > being worked on.
> > 
> > Please refer to FAQ in
> > http://www.chromium.org/developers/testing/try-server-usage
> > 
> > I believe the patch itself looks fine, but do you have any other idea   the
> > patch is wrong?
> > 
> > As you know, still I'm not commiter, so I need your help.
> > 
> > Actually I already landed more than 10 patches(including WebKit) so I could
be
> > commiter though;-)
> > 
> > Thanks,
> > 
> > On 2011/02/23 16:34:46, dhollowa wrote:
> > > I'm seeing a number of compile errors:
> > > 
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/13616/st...
> > > 
> > > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_amex.png',
> > > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > > `chrome/common/resources/autofill/cc_diners.png', needed by
> > > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > > `chrome/common/resources/autofill/cc_discover.png', needed by
> > > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > > `chrome/common/resources/autofill/cc_generic.png', needed by
> > > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_jcb.png',
> > > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > > `chrome/common/resources/autofill/cc_mastercard.png', needed by
> > > `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_solo.png',
> > > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > make: *** No rule to make target
> > `chrome/common/resources/autofill/cc_visa.png',
> > > needed by `out/Debug/obj/gen/chrome/grit/autofill_resources.h'.
> > > 
> > > 
> > > On 2011/02/23 06:58:58, honten wrote:
> > > > Hew.. I did it.
> > > > 
> > > > I was stuck because ld consumes fd more than default setting after I
pull
> > the
> > > > latest repo.
> > > > 
> > > > Anyway, please review again!!
> > > > 
> > > > On 2011/02/23 02:12:06, http://takano.naoki_gmail.com wrote:
> > > > > Ah... ok...
> > > > > 
> > > > > On Tue, Feb 22, 2011 at 5:30 PM,  <mailto:isherman@chromium.org>
wrote:
> > > > > > Could you please update this patch to ToT? &nbsp;The dom_ui folder
was
> > > moved
> > > > to
> > > > > > webui, so the patch no longer applies.
> > > > > >
> > > > > > http://codereview.chromium.org/6516002/
> > > > > >

[honten.org, 2011-02-26 00:26:35]

dhollowa,

Do you have any progress?

On 2011/02/23 19:27:47, dhollowa wrote:
> Takano, after thinking about this a little more I'm uneasy with a couple
points:
>  
>  (1) that this is Autofill specific, but if we are going to do this cleanup we
> should be thinking more generally.  I.e. why not move all resources out of the
> webkit glue layer?
> 
>  (2) the chrome/common/... area may not be were we want some of these
resources
> if they are renderer specific or browser specific.
> 
> Let me follow up with jam and darin to see what they think.

[honten.org, 2011-03-20 02:44:42]

dhollowa,

Do you have any update? I'm waiting for more than three weeks already;-)

If we don't touch this part anymore, please close this entry.

Thanks,

On 2011/02/26 00:26:35, honten wrote:
> dhollowa,
> 
> Do you have any progress?
> 
> On 2011/02/23 19:27:47, dhollowa wrote:
> > Takano, after thinking about this a little more I'm uneasy with a couple
> points:
> >  
> >  (1) that this is Autofill specific, but if we are going to do this cleanup
we
> > should be thinking more generally.  I.e. why not move all resources out of
the
> > webkit glue layer?
> > 
> >  (2) the chrome/common/... area may not be were we want some of these
> resources
> > if they are renderer specific or browser specific.
> > 
> > Let me follow up with jam and darin to see what they think.

[dhollowa, 2011-03-21 00:07:16]

Yes, I'll close this as it stand.  Sorry for the run-around.  This needs to be
done for everything if at all.  It doesn't make sense to do just the Autofill
pieces.  Thanks for the follow-up.