Issue 6515016: Restart named testing channel on disconnect.

Issue 6515016: Restart named testing channel on disconnect. (Closed)

Created:
9 years, 10 months ago by dtu

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Restart named testing channel on disconnect when using the named testing interface. BUG=chromium-os:8514 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75290

Patch Set 1 : Initial commit. #

Patch Set 2 : Permissions fixes and cleanup. #

Total comments: 4

Patch Set 3 : Changes per nirnimesh's comments. #

Patch Set 4 : Changes per nirnimesh's comments. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
M	chrome/browser/automation/automation_provider.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	1 2	4 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/6515016/diff/13006/chrome/browser/automation/automation_provider.cc File chrome/browser/automation/automation_provider.cc (right): http://codereview.chromium.org/6515016/diff/13006/chrome/browser/automation/automation_provider.cc#newcode456 chrome/browser/automation/automation_provider.cc:456: AutomationProviderList::GetInstance()->RemoveProvider(this); You won't need to repeat this RemoveProvider() call ...

9 years, 10 months ago (2011-02-17 00:55:12 UTC) #2

dtu

Done. http://codereview.chromium.org/6515016/diff/13006/chrome/browser/automation/automation_provider.cc File chrome/browser/automation/automation_provider.cc (right): http://codereview.chromium.org/6515016/diff/13006/chrome/browser/automation/automation_provider.cc#newcode456 chrome/browser/automation/automation_provider.cc:456: AutomationProviderList::GetInstance()->RemoveProvider(this); On 2011/02/17 00:55:12, Nirnimesh wrote: > You ...

9 years, 10 months ago (2011-02-17 02:14:25 UTC) #3

LGTM

Expand Messages | Collapse Messages