Issue 6515012: x64: Port OSR to the x64 platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6515012: x64: Port OSR to the x64 platform. (Closed)

Created:
9 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

x64: Port OSR to the x64 platform. Committed: http://code.google.com/p/v8/source/detail?r=6791

Patch Set 3 : '' #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -12 lines)			Patch
M	src/flag-definitions.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1 2	2 chunks	+62 lines, -2 lines	2 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 2	1 chunk	+39 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+14 lines, -2 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6515012/diff/9/src/x64/builtins-x64.cc File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/6515012/diff/9/src/x64/builtins-x64.cc#newcode1419 src/x64/builtins-x64.cc:1419: // a test(eax, depth) instruction right after the ...

9 years, 10 months ago (2011-02-14 16:02:30 UTC) #2

Rico

9 years, 10 months ago (2011-02-15 13:37:06 UTC) #3

http://codereview.chromium.org/6515012/diff/9/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

http://codereview.chromium.org/6515012/diff/9/src/x64/builtins-x64.cc#newcode...
src/x64/builtins-x64.cc:1419: // a test(eax, depth) instruction right after the
call.
On 2011/02/14 16:02:30, Kevin Millikin wrote:
> eax ==> rax

Done.

Expand Messages | Collapse Messages

Issue 6515012: x64: Port OSR to the x64 platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages