Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 6515011: Change kPointerSize to kIntSize in ia32 specific stack check patching.... (Closed)

Created:
9 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

Change kPointerSize to kIntSize in ia32 specific stack check patching. The call uses a 32 bit displacement relative to the next instruction. Althoug this has no actual impact on the 32 bit platform I think this is more correct (and will make the x64 and ia32 code more alike). Committed: http://code.google.com/p/v8/source/detail?r=6774

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M src/ia32/deoptimizer-ia32.cc View 1 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
9 years, 10 months ago (2011-02-14 13:16:51 UTC) #1
Karl Klose
LGTM.
9 years, 10 months ago (2011-02-14 13:37:36 UTC) #2
Rico
9 years, 10 months ago (2011-02-14 13:39:21 UTC) #3
Fixed indention

Powered by Google App Engine
This is Rietveld 408576698