Issue 6515009: FTP: Compatibility fix for "ls -l" style directory listing parser....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6515009: FTP: Compatibility fix for "ls -l" style directory listing parser.... (Closed)

Created:
9 years, 10 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

FTP: Compatibility fix for "ls -l" style directory listing parser. Some servers, for example smallftpd, add an empty line at the end of the listing. We should not fail on those. I think this bug was introduced in 2009 by http://codereview.chromium.org/449011 Now we have more test cases, and this change shouldn't introduce new compatibility problems. BUG=72060 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75079

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
A	net/data/ftp/dir-listing-ls-24	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/data/ftp/dir-listing-ls-24.expected	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_ls.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_ls.cc	View	2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages