Issue 6513006: Pass DictionaryValues directly to Autofill WebUI handlers

Issue 6513006: Pass DictionaryValues directly to Autofill WebUI handlers (Closed)

Created:
9 years, 10 months ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pass DictionaryValues directly to Autofill WebUI handlers BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74868

Patch Set 2 : Whitespace #

Total comments: 4

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -41 lines)			Patch
	M	chrome/browser/dom_ui/options/autofill_options_handler.cc	View	1	2 chunks	+30 lines, -39 lines	4 comments	Download
	M	chrome/browser/resources/options/autofill_options.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/options/autofill_options_handler.cc File chrome/browser/dom_ui/options/autofill_options_handler.cc (right): http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/options/autofill_options_handler.cc#newcode253 chrome/browser/dom_ui/options/autofill_options_handler.cc:253: DictionaryValue address; We can send DictionaryValue now?

9 years, 10 months ago (2011-02-12 20:37:34 UTC) #2

Ilya Sherman

9 years, 10 months ago (2011-02-13 12:24:59 UTC) #3

arv (Not doing code reviews)

LGTM http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/options/autofill_options_handler.cc File chrome/browser/dom_ui/options/autofill_options_handler.cc (right): http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/options/autofill_options_handler.cc#newcode253 chrome/browser/dom_ui/options/autofill_options_handler.cc:253: DictionaryValue address; On 2011/02/12 20:37:34, James Hawkins wrote: ...

9 years, 10 months ago (2011-02-14 18:41:44 UTC) #4

James Hawkins

9 years, 10 months ago (2011-02-16 20:43:59 UTC) #5

http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/option...
File chrome/browser/dom_ui/options/autofill_options_handler.cc (right):

http://codereview.chromium.org/6513006/diff/2001/chrome/browser/dom_ui/option...
chrome/browser/dom_ui/options/autofill_options_handler.cc:253: DictionaryValue
address;
On 2011/02/14 18:41:44, arv wrote:
> On 2011/02/12 20:37:34, James Hawkins wrote:
> > We can send DictionaryValue now?
> 
> Haven't we always been able to send all Value types from C++ to
> JS?CallJavascriptFunction JSON serializes the params so I DictionaryValue
works
> fine.

It's cool that we can now, and I'm not sure what's changed to fix it, but I know
when I originally wrote this, passing in a DictionaryValue didn't work.

Expand Messages | Collapse Messages