Issue 651079: Rework DEFAULT_FROM due to dependence on FLAGS_board.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651079: Rework DEFAULT_FROM due to dependence on FLAGS_board. (Closed)

Created:
10 years, 10 months ago by djmm

Modified:
9 years, 7 months ago

Reviewers:
tedbo, adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Rework DEFAULT_FROM due to dependence on FLAGS_board. Exit out if FLAGS_from doesn't exist. Use FLAGS_from in place of DEFAULT_from later on.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixarc #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
	M	src/scripts/archive_build.sh	View	1	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 10 months ago (2010-02-19 23:54:13 UTC) #3

LGTM w/ minor comments

http://codereview.chromium.org/651079/diff/1/2
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/651079/diff/1/2#newcode19
src/scripts/archive_build.sh:19: DEFAULT_FROM="${IMAGES_DIR}/$DEFAULT_BOARD/$(ls
-t1 $IMAGES_DIR/$DEFAULT_BOARD 2>&-| head -1)"
80 char wrap. a good place might be inside the $()

http://codereview.chromium.org/651079/diff/1/2#newcode41
src/scripts/archive_build.sh:41: FLAGS_from="${IMAGES_DIR}/$FLAGS_board/$(ls -t1
$IMAGES_DIR/$FLAGS_board 2>&-| head -1)"
80 cols

Expand Messages | Collapse Messages