Issue 651043: Enable chromeos reimage function from autoserv command line. Part I.

Issue 651043: Enable chromeos reimage function from autoserv command line. Part I. (Closed)

Created:
10 years, 10 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
mbligh, seano

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

This CL is serving more as a design review purpose. After I got LGTM, I wil send patch to upstream first. introduce a new command param on autoserv which accept a location of an os image, for ChromiumOS project. If user speficied --osimage on the command, it by default turn -i (install before) param to True. The actually implementation of os reimage is sitting inside site_hosts.py which will be checked in only into chromeos autotest.git, not kernel.org. Sean will be the owner of actually implementation.

Patch Set 1 #

Patch Set 2 : patch 2 #

Patch Set 3 : patch 3 #

Patch Set 4 : patch 5 #

Patch Set 5 : patch 5 #

Patch Set 6 : patch 5 #

Patch Set 7 : patch 6 #

Patch Set 8 : patch 8 #

Patch Set 9 : patch 9 #

Patch Set 10 : patch 19 #

Patch Set 11 : patch 10 #

Patch Set 12 : patch 12 #

Patch Set 13 : code review request. #

Total comments: 2

Patch Set 14 : patch 12 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
	A	server/hosts/site_host.py	View	2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	server/site_autoserv_parser.py	View	11 12 13	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

seano

LGTM http://codereview.chromium.org/651043/diff/1039/1040 File server/hosts/site_host.py (right): http://codereview.chromium.org/651043/diff/1039/1040#newcode10 server/hosts/site_host.py:10: print "Install %s to host:%s" % (image, self.hostname) ...

10 years, 10 months ago (2010-02-22 16:59:44 UTC) #2

ericli

10 years, 10 months ago (2010-02-22 17:04:36 UTC) #3

Fixed.

Sean,

You will own site_hosts.py in the future for real implementations.

Eric

On 2010/02/22 16:59:44, seano wrote:
> LGTM
> 
> http://codereview.chromium.org/651043/diff/1039/1040
> File server/hosts/site_host.py (right):
> 
> http://codereview.chromium.org/651043/diff/1039/1040#newcode10
> server/hosts/site_host.py:10: print "Install %s to host:%s" % (image,
> self.hostname)
> space between host: and %s
> 
> http://codereview.chromium.org/651043/diff/1039/1041
> File server/site_autoserv_parser.py (right):
> 
> http://codereview.chromium.org/651043/diff/1039/1041#newcode22
> server/site_autoserv_parser.py:22: help="Location of an osimage to install.")
> maybe help="Full path of install image."

Expand Messages | Collapse Messages