Issue 651028: Added test for bug 619 - we should move this to object-define-property when t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651028: Added test for bug 619 - we should move this to object-define-property when t... (Closed)

Created:
10 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added test for bug 619 - we should move this to object-define-property when the bug has been corrected. Committed: http://code.google.com/p/v8/source/detail?r=3918

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -0 lines)			Patch
	A	test/mjsunit/bugs/bug-619.js	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 10 months ago (2010-02-19 13:20:04 UTC) #2

LGTM

http://codereview.chromium.org/651028/diff/1/2
File test/mjsunit/bugs/bug-619.js (right):

http://codereview.chromium.org/651028/diff/1/2#newcode38
test/mjsunit/bugs/bug-619.js:38: // we should not be able to override obj[1]
Capitalize comments and end with period.

Expand Messages | Collapse Messages