Issue 651024: Add missing break in GetPropertyWithFailedAccessCheck. This break has...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651024: Add missing break in GetPropertyWithFailedAccessCheck. This break has... (Closed)

Created:
10 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add missing break in GetPropertyWithFailedAccessCheck. This break has been missing for a long time but the fallthrough to the default case used to break. Now the default case should be unreachable and the fallthrough therefore causes assertion failures. Committed: http://code.google.com/p/v8/source/detail?r=3913

Patch Set 1 #

Created: 10 years, 10 months ago

		Unified diffs	Side-by-side diffs	Stats (+1 line, -0 lines)
	M	src/objects.cc	View	1 chunk	+1 line, -0 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages