Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 6508006: Enable EFIv1 compression in bmpbklk_utility. (Closed)

Created:
9 years, 10 months ago by Bill Richardson
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Enable EFIv1 compression in bmpbklk_utility. This lets bmpbklk_utility generate BMPBLOCKs with EFIv1-compressed bitmaps. It also adds the ability to display or unpack BMPBLOCK blobs. The compression/decompression routines come from the tianocore EDK on sourceforge and are written in C, so now there's a mix of C and C++, but it works just fine. BUG=chromium-os:11491 TEST=manual cd src/platform/vboot_reference make make runbmptests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=61362d6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added tests, updated copyrights, moved bmpblk_util.h as suggested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3121 lines, -44 lines) Patch
A tests/bitmaps/Background.bmp View 1 Binary file 0 comments Download
M tests/bitmaps/TestBmpBlock.py View 1 2 chunks +67 lines, -1 line 0 comments Download
A tests/bitmaps/Word.bmp View 1 Binary file 0 comments Download
A tests/bitmaps/case_simple.yaml View 1 1 chunk +27 lines, -0 lines 0 comments Download
M utility/Makefile View 1 chunk +9 lines, -1 line 0 comments Download
M utility/bmpblk_util.c View 4 chunks +250 lines, -15 lines 0 comments Download
M utility/bmpblk_utility.cc View 1 9 chunks +56 lines, -25 lines 0 comments Download
A utility/eficompress.c View 1 1 chunk +1609 lines, -0 lines 0 comments Download
A utility/efidecompress.c View 1 1 chunk +1008 lines, -0 lines 0 comments Download
M utility/include/bmpblk_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M utility/include/bmpblk_utility.h View 2 chunks +7 lines, -0 lines 0 comments Download
A utility/include/eficompress.h View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Richardson
9 years, 10 months ago (2011-02-11 23:24:24 UTC) #1
Randall Spangler
LGTM http://codereview.chromium.org/6508006/diff/1/utility/bmpblk_util.c File utility/bmpblk_util.c (right): http://codereview.chromium.org/6508006/diff/1/utility/bmpblk_util.c#newcode65 utility/bmpblk_util.c:65: static int require_dir(const char *dirname) { Could move ...
9 years, 10 months ago (2011-02-11 23:44:02 UTC) #2
Bill Richardson
I tried; hostlib fights with all the various include files and the g++ compiler. Not ...
9 years, 10 months ago (2011-02-12 00:12:33 UTC) #3
Randall Spangler
(LGTM regardless) On Fri, Feb 11, 2011 at 4:12 PM, <wfrichar@chromium.org> wrote: > I tried; ...
9 years, 10 months ago (2011-02-12 00:14:54 UTC) #4
Tom Wai-Hong Tam
9 years, 10 months ago (2011-02-14 04:24:42 UTC) #5
LGTM

The path of bmpblk_util.h header file should be utility/include/ instead of
firmware/include/.

Powered by Google App Engine
This is Rietveld 408576698