All tests based on cros_ui_test.UITest now get crash checking for free.

All tests based on cros_ui_test.UITest now get crash checking for free.

Too many times a test has failed with some weird error message due to a crash elsewhere in the system. Time is wasted on investigation when a crash is the real source. To make crashes clearer, all tests instantiating cros_ui_test.UITest will now raise test failures for crashes occuring during a test run. To disable this behavior they merely need to set self.ignore_crashes = True.

Sample output:
14:55:33 INFO | START	----	----	timestamp=1297464933	localtime=Feb 11 14:55:33	
14:55:33 INFO | 	START	desktopui_FlashSanityCheck	desktopui_FlashSanityCheck	timestamp=1297464933	localtime=Feb 11 14:55:33	
14:56:24 INFO | 		INFO	desktopui_FlashSanityCheck	Crash detected: Xorg[10058] sig 11 (ignoring - no consent)	timestamp=1297464984	localtime=Feb 11 14:56:24	
14:56:25 INFO | 		FAIL	desktopui_FlashSanityCheck	desktopui_FlashSanityCheck	timestamp=1297464985	localtime=Feb 11 14:56:25	Crash(es) detected: Xorg[10058] sig 11 (ignoring - no consent)
14:56:25 INFO | 	END FAIL	desktopui_FlashSanityCheck	desktopui_FlashSanityCheck	timestamp=1297464985	localtime=Feb 11 14:56:25	
14:56:27 INFO | END GOOD	----	----	timestamp=1297464987	localtime=Feb 11 14:56:27	

Full list of affected tests:
audiovideo_PlaybackRecordSemiAuto
desktopui_ChromeFirstRender
desktopui_FlashSanityCheck
desktopui_IBusTest
desktopui_ImeTest
desktopui_ScreenLocker
desktopui_SunSpiderBench
desktopui_V8Bench
desktopui_WindowManagerFocusNewWindows
desktopui_WindowManagerHotkeys
graphics_GLAPICheck
graphics_O3DSelenium
graphics_SanAngeles
graphics_TearTest
graphics_WebGLConformance
graphics_WindowManagerGraphicsCapture
hardware_BluetoothSemiAuto
logging_LogVolume
logging_UncleanShutdown
login_Backdoor
login_BadAuthentication
login_ChromeProfileSanitary
login_CryptohomeIncognitoMounted
login_CryptohomeIncognitoUnmounted
login_CryptohomeMounted
login_CryptohomeUnmounted
login_DBusCalls
login_LoginSuccess
login_LogoutProcessCleanup
login_OwnershipNotRetaken
login_OwnershipTaken
login_RemoteLogin
login_SecondFactor
platform_ProcessPrivileges
platform_ProcessPrivilegesComprehensive
power_Idle
power_LoadTest
security_NetworkListeners
security_RendererSandbox

Change-Id: I4225e4a12876a4ff9e1f1a082d86c8baece703e2

BUG=chromium-os:12100
TEST=Ran run_remote_tests w/ a known crashing build.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4df0c13

[DaleCurtis, 2011-02-11 23:03:44]

Adding sosa as change will affect preflight queue smoke tests. I'll send out a
PSA as well once the change goes in.

[ericli, 2011-02-11 23:12:22]

LGTM.

[davidjames, 2011-02-11 23:22:47]

This change looks great! It will be very helpful for Sheriffs.

Could you update FlashSanityCheck to get rid of the old code that raised an
error saying 'Browser crashed during test' when any program crashes? With your
fix, I guess that old code is obsolete.

[sosa, 2011-02-15 00:35:35]

LGTM