Issue 6507028: Remove usages of RootView from View by moving relevant RootView API methods t...

Issue 6507028: Remove usages of RootView from View by moving relevant RootView API methods t... (Closed)

Created:
9 years, 10 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove usages of RootView from View by moving relevant RootView API methods to Widget. This results in some code duplication right now but this will be mitigated once all platforms use WidgetImpl. http://crbug.com/72040 TEST=existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75431

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -199 lines)			Patch
M	chrome/browser/bookmarks/bookmark_utils.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/dragged_tab_controller.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	views/view.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	views/view.cc	View		8 chunks	+16 lines, -29 lines	0 comments	Download
M	views/widget/native_widget.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	views/widget/native_widget_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	views/widget/root_view.h	View		4 chunks	+0 lines, -24 lines	0 comments	Download
M	views/widget/root_view.cc	View		6 chunks	+11 lines, -79 lines	0 comments	Download
M	views/widget/root_view_gtk.cc	View	1 2 3	1 chunk	+0 lines, -16 lines	0 comments	Download
M	views/widget/root_view_win.cc	View		2 chunks	+1 line, -27 lines	0 comments	Download
M	views/widget/widget.h	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	views/widget/widget_gtk.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	views/widget/widget_gtk.cc	View	1 2 3 4	4 chunks	+35 lines, -1 line	0 comments	Download
M	views/widget/widget_impl.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	views/widget/widget_impl.cc	View	1 2 3	4 chunks	+31 lines, -2 lines	0 comments	Download
M	views/widget/widget_win.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	views/widget/widget_win.cc	View	1 2 3	5 chunks	+39 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 10 months ago (2011-02-17 00:37:46 UTC) #2

LGTM with the following changes.

http://codereview.chromium.org/6507028/diff/6005/views/widget/widget_gtk.cc
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/6507028/diff/6005/views/widget/widget_gtk.cc#n...
views/widget/widget_gtk.cc:870: // If the view is removed during the drag
operation, drag_view_ is set to
drag_view_ -> dragged_view_

http://codereview.chromium.org/6507028/diff/6005/views/widget/widget_impl.cc
File views/widget/widget_impl.cc (right):

http://codereview.chromium.org/6507028/diff/6005/views/widget/widget_impl.cc#...
views/widget/widget_impl.cc:374: ViewStorage::GetInstance()->ViewRemoved(parent,
child);
Don't you need the:

if (child == dragged_view_)
  dragged_view_ = NULL
?

Expand Messages | Collapse Messages