Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 6507019: Use class instead of attribute for hide-menu (Closed)

Created:
9 years, 10 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Use class instead of attribute for hide-menu Works around webkit bug 12519 BUG=73047 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75221

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/resources/options/options.js View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/options_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
The appendChild/removeChild hack didn't work, for some reason. This approach seems no more awful. hide-menu ...
9 years, 10 months ago (2011-02-16 21:29:23 UTC) #1
James Hawkins
9 years, 10 months ago (2011-02-16 21:34:00 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698